899863 - ChannelMediaResource should treat resources with a Content-Length as finite

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

In bug 619752, we talked about treating resources with a Content-Length as finite, but the patch only checks the Content-Duration header (and its aliases). This means when the channel does not support range requests (which includes a Necko response!), and the resource doesn't have a Content-Duration header, we report its duration as infinite (even if we successfully decode a duration from the container).

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I meant "Necko cache response".

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Ensure resources with a Content-Length (that's not the result of a range request) are treated as bounded

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e14729d47ea8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e14729d47ea8

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 783493 [details] [diff] [review]
Ensure resources with a Content-Length (that's not the result of a range request) are treated as bounded

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: none, probably; but needed for Web Audio to work on Aurora
Testing completed (on m-c, etc.): been on m-c for a week or so
Risk to taking this patch (and alternatives if risky): pretty low risk
String or IDL/UUID changes made by this patch: none

Comment 6

[Paul Adenot (:padenot)]

Approval ping? This is blocking a bunch of WebAudio patches to be landed on Aurora.

Comment 7

[(no longer active)]

(In reply to Paul Adenot (:padenot) from comment #6)
> Approval ping? This is blocking a bunch of WebAudio patches to be landed on
> Aurora.

Ping?

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 783493 [details] [diff] [review]
Ensure resources with a Content-Length (that's not the result of a range request) are treated as bounded

Apologies, at a Stability work week and behind on approvals.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/61cbf67c2fc4