899946 - strange call to crypto.generateCRMFRequest from test_bug882865.html

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(The test case is from Bug 882865, but I don't have permission to access Bug 882865)
In http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/tests/mochitest/bugs/test_bug882865.html?force=1#28

The call to generateCRMFRequest is 

25     var o200 = document.documentElement;
26     var o1 = crypto;
27     try {
28       o1.generateCRMFRequest(o200.writeln, o200, 'X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X', null, o1, 1404343237, Math.PI, []);


But the 1st parameter o200.writeln is undefined
(Or maybe it should be document.writeln?), so the test should fail with 1st argument reqDN is missing.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The current generateCRMFRequest code checks argv[0] for null, but not for undefined.

So in the current code, the above will invoke JS_ValueToString() on undefined, producing "undefined".

I suspect that just changing the test to pass in "undefined" there will not affect what it's testing, for what it's worth.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

bz is correct.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

replace it with double quotes.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try result
https://tbpl.mozilla.org/?tree=Try&rev=0ed023367e47

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21bc76970edc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21bc76970edc