899965 - Test failure "controller.waitForPageLoad(): Timeout waiting for page loaded." in /restartTests/testAddons_installUninstallHardBlocklistedExtension

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andreea Matei [:AndreeaMatei]]

This fails every time in Mozmill 2.0, after the restart between test2 and test3.
I suspect now it might be related to the blocklist dialog that remains somehow unhandled, since we do a forced restart between tests while the dialog is still opened.
The dialog has a restart button we should use. This should fix both blocklist tests (the softblocked is nearly done).
Same applies for 1.5.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Andreea, can you test to see if dismissing the dialog would be a suitable workaround until we have bug 886360?

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Sorry, missed that Cosmin is assigned. I don't mind who works on it. :)

Comment 3

[Cosmin Malutan, [:cosmin-malutan]]

Here the actual problem is that in test3.js the addons manager tab is already open so we have to close it in teardown. I already have the patch and is tested but I'm waiting for bug 886811 to be landed, because otherwise the bug dose't reproduce in testrun and I can't make reports.

Comment 4

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch_v1.0

Mozmill 2.0:
http://mozmill-crowd.blargon7.com/#/functional/report/e503b7b0a70a3839c66c64572ebac51d
http://mozmill-crowd.blargon7.com/#/functional/report/e503b7b0a70a3839c66c64572ebc5244
http://mozmill-crowd.blargon7.com/#/functional/report/e503b7b0a70a3839c66c64572ebdc088
Mozmill 1.5:
http://mozmill-crowd.blargon7.com/#/functional/report/e503b7b0a70a3839c66c64572eb60b93
http://mozmill-crowd.blargon7.com/#/functional/report/e503b7b0a70a3839c66c64572eb60aaf
http://mozmill-crowd.blargon7.com/#/functional/report/e503b7b0a70a3839c66c64572eb6126f

Comment 5

[Andrei Eftimie]

Comment on attachment 793454 [details] [diff] [review]
patch_v1.0

Review of attachment 793454 [details] [diff] [review]:
-----------------------------------------------------------------

As a note: to correctly see this problem, have the patch from bug 886811 applied first.
Please see inline further comments.

I think we might only need to call aModule.addonsManager.close(); in teardown to fix this problem.
The reported failure reproduces no more with only that change.
Please test, and if that is the case, we can probably remove all other changes.

I see however another failure after we fix this one.
> "message": "Category has been changed.", 

Please see if it is related and if it should be fixed here, or open another bug for it.

::: tests/functional/restartTests/testAddons_installUninstallHardBlocklistedExtension/test2.js
@@ +33,5 @@
> +    var acceptButton = aModule.blocklistWindow.getElement({type: "acceptButton" });
> +    assert.ok(acceptButton.exists(),"Accept Button exists");
> +
> +    aModule.controller.startUserShutdown(TIMEOUT_USER_SHUTDOWN, true);
> +    aModule.controller.click(acceptButton);

Why do we need this whole block?
Isn't this failure only occuring with mozmill 2.0?
This block is only run under 1.5
Do we get this failure there as well?

::: tests/functional/restartTests/testAddons_installUninstallSoftBlocklistedExtension/test2.js
@@ +33,5 @@
> +    var acceptButton = aModule.blocklistWindow.getElement({type: "acceptButton" });
> +    assert.ok(acceptButton.exists(),"Accept Button exists");
> +
> +    aModule.controller.startUserShutdown(TIMEOUT_USER_SHUTDOWN, true);
> +    aModule.controller.click(acceptButton);

Same as above

Comment 6

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch_v2.0

(In reply to Andrei Eftimie from comment #5)
> I see however another failure after we fix this one.
> > "message": "Category has been changed.", 
> 
> Please see if it is related and if it should be fixed here, or open another
> bug for it.
I didn't see this error.

> Why do we need this whole block?
> Isn't this failure only occuring with mozmill 2.0?
> This block is only run under 1.5
> Do we get this failure there as well?
You're right, we don't, we discussed before to click on restart button after addon is installed but i don't think it's not necessary so I dropped that part.

Here are the new reports:
http://mozmill-crowd.blargon7.com/#/functional/report/6d53b7d749a60e65551b4b1d197c33ed 
http://mozmill-crowd.blargon7.com/#/functional/report/6d53b7d749a60e65551b4b1d197c3c8a
http://mozmill-crowd.blargon7.com/#/functional/report/6d53b7d749a60e65551b4b1d197c4793

Comment 7

[Andrei Eftimie]

Comment on attachment 795302 [details] [diff] [review]
patch_v2.0

Review of attachment 795302 [details] [diff] [review]:
-----------------------------------------------------------------

Much better and cleaner!

Please post some testruns under mozmill 1.5 then request a checkin from Andreea

Comment 8

[Cosmin Malutan, [:cosmin-malutan]]

Reports for 1.5
http://mozmill-crowd.blargon7.com/#/functional/report/6d53b7d749a60e65551b4b1d198bbf9b
http://mozmill-crowd.blargon7.com/#/functional/report/6d53b7d749a60e65551b4b1d198dd7ab
http://mozmill-crowd.blargon7.com/#/functional/report/6d53b7d749a60e65551b4b1d198ad079
Andreea could you please checkin my patch,
Thanks

Comment 9

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 795302 [details] [diff] [review]
patch_v2.0

Review of attachment 795302 [details] [diff] [review]:
-----------------------------------------------------------------

Please also add a blank line between the close() method and the comment.

Comment 10

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch_v2.1

Comment 11

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 795432 [details] [diff] [review]
patch_v2.1

Review of attachment 795432 [details] [diff] [review]:
-----------------------------------------------------------------

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/d29d5c0724c1 (default)

Not sure if other branches are affected here in 2.0, might be good to backport. Please check that.

Comment 12

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch_v2.2

All the branches are affected, the patch applies clearly and fixes the issue on Aurora and Beta, and I attached a new patch for Release and Esr17.

Comment 13

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 795940 [details] [diff] [review]
patch_v2.2

Review of attachment 795940 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/7c780c882340 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/92794bc25b22 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/4c252722acda (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/8516a634b8c1 (esr17)