Closed
Bug 899970
Opened 11 years ago
Closed 11 years ago
GC: Post barrier heap pointers in js/ipc
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
3.63 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #783704 -
Flags: review?(terrence)
Assignee | ||
Comment 1•11 years ago
|
||
This is for a couple of calls to JS_CallObjectTracer() that got added after the last browser post barrier updates.
Comment 2•11 years ago
|
||
Comment on attachment 783704 [details] [diff] [review] post-barrier-ipc Review of attachment 783704 [details] [diff] [review]: ----------------------------------------------------------------- r=me ::: js/ipc/JavaScriptShared.cpp @@ +29,5 @@ > ObjectStore::trace(JSTracer *trc) > { > for (ObjectTable::Range r(table_.all()); !r.empty(); r.popFront()) { > +#ifdef DEBUG > + JSObject *prior = r.front().value; Please change this to a mozilla::DebugOnly<JSObject *>, instead of the #ifdef DEBUG guards. ::: js/ipc/JavaScriptShared.h @@ +71,5 @@ > > bool init(); > void trace(JSTracer *trc); > > + bool add(JSContext *cx, JSObject *, ObjectId id); Give the |obj| parameter its name, while you are here. @@ +76,5 @@ > ObjectId find(JSObject *obj); > void remove(JSObject *obj); > > private: > + static void keyMarkCallback(JSTracer *trc, void *k, void *d); |key| and |data| rather than k and d.
Attachment #783704 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Terrence Cole [:terrence] from comment #2) > Please change this to a mozilla::DebugOnly<JSObject *> Ah I knew there was a better way. Other comments addressed.
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e96bc10145e9
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e96bc10145e9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•