90001 - <scrollbar>, <thumb>, and <slider> should not use align="vertical" and align="horizontal"

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mark Anderson]

See the summary.  The usage of align="vertical" and align="horizontal" in 
<scrollbar> and its derivative tags is inconsistent with all other elements in 
XUL.  Windows Classic seems to support an attribute called sborient.  Modern and 
Mac Classic should probably do the same.

Comment 1

[Mike Pinkerton (not reading bugmail)]

xbl/xul work

Comment 2

[[e-mail]]

No it doesn't, it inherits align but renames it to sborient.

http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/classicBindings.xml#80

<xul:scrollbarbutton type="decrement" inherits="sborient=align"/>
Also on line 84.

IIRC Changing align to orient would fix the base scrollbar binding.

Comment 3

[Mark Anderson]

Well, cool.  hewitt managed to fix this for Modern.  I'm now attaching a patch 
that should do it for Mac Classic (although I can't test it).

Of course, with both Modern and Mac Classic working, we could just use orient= 
in Windows Classic and not do the remapping, but that's not my call (or 
terribly important). :)

Comment 4

[Mark Anderson]

Attachment: Mac Classic patch (should work, but needs testing by a Mac person)

Comment 5

[Mark Anderson]

Well, I replaced my classic.jar's classicBindings.xml and scrollbars.css with 
the patched Mac Classic ones, and the scrollbars weren't horked (other than 
using some images that aren't in Windows Classic, so they were pure white), so I 
guess it works.  The test was basically that the scrollbars looked ok and 
scrolled, which they did, so I guess this patch works. :)

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

[s]r=[e-mail]

Comment 7

[David Hyatt]

sr=hyatt

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in.