Add a <noscript> block to webmaker.org

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: arhayward, Assigned: Zakeria Hassan)

Tracking

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
jbuck
: review+
alicoding
: review+
inactivate account for kate
: review+
Details | Review | Splinter Review
(Reporter)

Description

5 years ago
Right now, the webmaker.org site is broken, superficially at least, without JavaScript. The usual expectation when coming to a page and being presented with a 'loading' graphic (feline or otherwise) is that something is loading. However, without JavaScript, nothing changes, suggesting to the user that something somewhere is either taking a long time to load, or is not going to load at all.

This is neither the time nor the place to discuss the decision to pull in all content with JavaScript, but I would suggest that at the very least a <noscript> block be included to let people know that nothing is ever going to load, and they they'll have to enable it to get much further.
(Assignee)

Comment 1

4 years ago
Hi,
Can someone assign this bug to me.

Thanks
Assignee: nobody → zak.hassan1010
(Assignee)

Comment 2

4 years ago
I removed the static text and used get text. I'm sure there will be localization done to this error page. Please let me know if there is anything else.
Awaiting r+
Ali to review...
(Assignee)

Updated

4 years ago
Attachment #817584 - Flags: review?(andrew) → review?(jon)
(Assignee)

Updated

4 years ago
Attachment #817584 - Flags: review?(ali)
Attachment mime type: text/plain → text/x-github-pull-request
(Assignee)

Comment 5

4 years ago
is the one nit the new line on line 109 of view/layout.html if it is then I've removed it.

Comment 6

4 years ago
Comment on attachment 817584 [details] [review]
https://github.com/mozilla/webmaker.org/pull/428

We've changed the layout of webmaker.org so that the front page is actually pretty functional without Javascript now. https://webmaker.org/starter-makes and https://webmaker.org/teach still need JS though.

I'd recommend editing views/gallery.html to add a <noscript> block in place of the animated kitty gif, rather than doing a page redirect. It'll be less intrusive, and more accurate, since many parts of the site work fine without JS
Attachment #817584 - Flags: review?(jon) → review-
(Assignee)

Comment 7

4 years ago
Comment on attachment 817584 [details] [review]
https://github.com/mozilla/webmaker.org/pull/428

@Jon:

Thanks Jon. I've implemented the fix's to the comment you posted. Please see the latest code at the following link.

https://github.com/mozilla/webmaker.org/pull/428/files
Attachment #817584 - Flags: review- → review?(jon)

Comment 8

4 years ago
Comment on attachment 817584 [details] [review]
https://github.com/mozilla/webmaker.org/pull/428

r+ with nits noted in the PR.

This looks good from a code perspective, but I think the design needs some work: https://dl.dropboxusercontent.com/u/4403845/Screenshots/br.png.
Attachment #817584 - Flags: review?(kate)
Attachment #817584 - Flags: review?(jon)
Attachment #817584 - Flags: review+
Comment on attachment 817584 [details] [review]
https://github.com/mozilla/webmaker.org/pull/428

Ideally the loading cat should also be hidden, but otherwise this looks OK to me
Attachment #817584 - Flags: review?(kate) → review+
(Assignee)

Comment 10

4 years ago
Hi,

Can we set this bug to Resolved status since both reviewers have given me a r+.

Thanks,
Zak
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(andrew)
Resolution: --- → WORKSFORME
Please rebase and merge your commits and I will be happy to land that for you.
(Assignee)

Comment 12

4 years ago
Ok thanks I will rebase.
(Assignee)

Comment 13

4 years ago
Rebase is complete please land when you get a chance.

thank you.

Comment 14

4 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/a9e1b03f774a91a0f52cb2b8a970c823ce38e149
Bug900025: Add a <noscript> block to webmaker.org only required on /gallery
Flags: needinfo?(andrew)
Resolution: WORKSFORME → FIXED
You need to log in before you can comment on or make changes to this bug.