Hi, Can someone assign this bug to me. Thanks
I removed the static text and used get text. I'm sure there will be localization done to this error page. Please let me know if there is anything else. Awaiting r+ Ali to review...
Attachment #817584 - Flags: review?(andrew)
Attachment #817584 - Flags: review?(andrew) → review?(jon)
Attachment mime type: text/plain → text/x-github-pull-request
Comment on attachment 817584 [details] [review] https://github.com/mozilla/webmaker.org/pull/428 r+ with one nit
Attachment #817584 - Flags: review?(ali) → review+
is the one nit the new line on line 109 of view/layout.html if it is then I've removed it.
Attachment #817584 - Flags: review?(jon) → review-
Comment on attachment 817584 [details] [review] https://github.com/mozilla/webmaker.org/pull/428 @Jon: Thanks Jon. I've implemented the fix's to the comment you posted. Please see the latest code at the following link. https://github.com/mozilla/webmaker.org/pull/428/files
Attachment #817584 - Flags: review- → review?(jon)
Comment on attachment 817584 [details] [review] https://github.com/mozilla/webmaker.org/pull/428 r+ with nits noted in the PR. This looks good from a code perspective, but I think the design needs some work: https://dl.dropboxusercontent.com/u/4403845/Screenshots/br.png.
Comment on attachment 817584 [details] [review] https://github.com/mozilla/webmaker.org/pull/428 Ideally the loading cat should also be hidden, but otherwise this looks OK to me
Attachment #817584 - Flags: review?(kate) → review+
Hi, Can we set this bug to Resolved status since both reviewers have given me a r+. Thanks, Zak
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WORKSFORME
Please rebase and merge your commits and I will be happy to land that for you.
Ok thanks I will rebase.
Rebase is complete please land when you get a chance. thank you.
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/a9e1b03f774a91a0f52cb2b8a970c823ce38e149 Bug900025: Add a <noscript> block to webmaker.org only required on /gallery
Resolution: WORKSFORME → FIXED
You need to log in before you can comment on or make changes to this bug.