Closed
Bug 900211
Opened 12 years ago
Closed 12 years ago
Rocketbar visual polish
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 784007 [details]
Github Pull Request
Vivien or Sam - Just looking for a quick review on these changes. Mostly visual with a small JS tweak.
Attachment #784007 -
Flags: review?(sjochimek)
Attachment #784007 -
Flags: review?(21)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 784007 [details]
Github Pull Request
need small update -- its r+ for me.
Attachment #784007 -
Flags: review?(sjochimek) → review+
|
||
Comment 4•12 years ago
|
||
Comment on attachment 784007 [details]
Github Pull Request
I'm fine with Sam's review. I think that the icon should be inlined though.
Attachment #784007 -
Flags: review?(21)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Thanks guys, fixed those issues and landed in master: https://github.com/mozilla-b2g/gaia/commit/df214733298f758bf9053983fed9acc960200872
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•