900228 - "TypeError: this.selectedEditor.sourceEditor is null: @resource:///modules/devtools/StyleEditorUI.jsm:154" in green debug mochitest-browser-chrome runs

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Ed Morley [:emorley]]

A recently deployed TBPL parser improvement has found a whole bunch of log spam in green debug mochitest-browser-chrome runs.

a) Should these be making the test run fail?
b) We should handle/fix, so we don't spam the annotated failure summary.

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=25965644&tree=Mozilla-Inbound#error2

{
04:31:35     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "Error in parsing value for '-moz-box-ordinal-group'.  Declaration dropped." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0 column: 0 source: "-1"}]
04:31:35     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "Error in parsing value for '-moz-box-ordinal-group'.  Declaration dropped." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0 column: 0 source: "-1"}]
04:31:35     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "Error in parsing value for '-moz-box-ordinal-group'.  Declaration dropped." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0 column: 0 source: "-1"}]
04:31:35     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}]
04:31:35     INFO -  TypeError: this.selectedEditor.sourceEditor is null: @resource:///modules/devtools/StyleEditorUI.jsm:154
}

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleeditor/StyleEditorUI.jsm#154
{
147   /**
148    * Handler for debuggee's 'stylesheets-cleared' event. Remove all editors.
149    */
150   _onStyleSheetsCleared: function() {
151     // remember selected sheet and line number for next load
152     if (this.selectedEditor) {
153       let href = this.selectedEditor.styleSheet.href;
154       let {line, col} = this.selectedEditor.sourceEditor.getCaretPosition();
155       this.selectStyleSheet(href, line, col);
156     }
157 
158     this._clearStyleSheetEditors();
159     this._view.removeAll();
160 
161     this.selectedEditor = null;
162 
163     this._root.classList.add("loading");
164   },
}

Comment 1

[Heather Arthur [:harth]]

This shouldn't be too hard to fix, I imagine.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

(In reply to Heather Arthur [:harth] from comment #1)
> This shouldn't be too hard to fix, I imagine.

I assume it's safe to assign this to you then? :)

Comment 3

[Heather Arthur [:harth]]

Attachment: se-null.patch

Fix for the "TypeError: this.selectedEditor.sourceEditor is null". I can't figure out where that -moz-box-ordinal-group is coming from.

Comment 4

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/448547a2084e

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/448547a2084e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

(In reply to Heather Arthur [:harth] from comment #3)

Thanks!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b6f625c1fb9c

Comment 8

[u279076]

Assuming no QA needed here. Please remove [qa-] from the whiteboard and add the verifyme keyword if this needs QA.