Closed Bug 900257 Opened 6 years ago Closed 6 years ago

IonMonkey: inline Math.fround

Categories

(Core :: JavaScript Engine, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: bbouvier, Assigned: bbouvier)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Once Math.toFloat32 is added to the interpreter, we should inline it in IonMonkey as soon as possible.
Attached patch proposed implementation (obsolete) — Splinter Review
Attachment #784120 - Flags: review?(sstangl)
Attached patch rebased (obsolete) — Splinter Review
Attachment #784120 - Attachment is obsolete: true
Attachment #784120 - Flags: review?(sstangl)
Attachment #797476 - Flags: review?(sstangl)
Comment on attachment 797476 [details] [diff] [review]
rebased

Review of attachment 797476 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/IonBuilder.h
@@ +514,5 @@
>      InliningStatus inlineMathMinMax(CallInfo &callInfo, bool max);
>      InliningStatus inlineMathPow(CallInfo &callInfo);
>      InliningStatus inlineMathRandom(CallInfo &callInfo);
>      InliningStatus inlineMathImul(CallInfo &callInfo);
> +    InliningStatus inlineMathFround(CallInfo &callInfo);

Could we capitalize this function as "inlineMathFRound"?
Attachment #797476 - Flags: review?(sstangl) → review+
(In reply to Sean Stangl [:sstangl] from comment #3)
> Could we capitalize this function as "inlineMathFRound"?

Sure!
Attachment #797476 - Attachment is obsolete: true
Attachment #799157 - Flags: review+
Blocks: 913253
Blocks: 913282
https://hg.mozilla.org/mozilla-central/rev/8621bdc40841
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Summary: IonMonkey: inline Math.toFloat32 → IonMonkey: inline Math.fround
Depends on: 939868
Depends on: 958381
Depends on: 919522
You need to log in before you can comment on or make changes to this bug.