900257 - IonMonkey: inline Math.fround

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Once Math.toFloat32 is added to the interpreter, we should inline it in IonMonkey as soon as possible.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: proposed implementation

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: rebased

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 797476 [details] [diff] [review]
rebased

Review of attachment 797476 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/IonBuilder.h
@@ +514,5 @@
>      InliningStatus inlineMathMinMax(CallInfo &callInfo, bool max);
>      InliningStatus inlineMathPow(CallInfo &callInfo);
>      InliningStatus inlineMathRandom(CallInfo &callInfo);
>      InliningStatus inlineMathImul(CallInfo &callInfo);
> +    InliningStatus inlineMathFround(CallInfo &callInfo);

Could we capitalize this function as "inlineMathFRound"?

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: rebased + renamed

(In reply to Sean Stangl [:sstangl] from comment #3)
> Could we capitalize this function as "inlineMathFRound"?

Sure!

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8621bdc40841

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8621bdc40841