900287 - Issue with sorting by Locale in new set up

Status: RESOLVED FIXED

(Snippets :: Service, defect)

Description

[Winston Bowden]

Hi Mike, 

We were trying to review all snippets set to Locale: es.  I can see them when I look at the string.  There are two running right now.  See below:

https://snippets.mozilla.com/1/Firefox/22.0/20110901042012/Darwin_Universal-gcc3/es/release/Darwin%2010.8.0/default/default/

When we are in the admin and we click "Locale: es" we're not seeing the two active Movistar snippets.  

I tested to see what would happen if I took a snippet that was imported and removed client match rules and applied the new formatting (assign locale and check which version of Firefox).  "Firefox Aurora in Beta Channel #3 es" was showing up when I clicked "locale: es" originally.  However, when I removed the client match rule and set it up in the new format it disappeared.  I can see it on the string, but not in the admin.

Jean can explain if my description is confusing.

Comment 1

[Osmose [:osmose, :mkelly]]

So those filters you clicked are for filtering by client match rule, not by locale. Since those two snippets in ES aren't using the client match rules for their locale, filtering by the "Locale: es" rule won't show them.

I've put up a pull request that's currently under review that adds a specific filter for locales, and also lets you filter by template so you can hide any snippets that are using the import template in case you only want to see newer snippets. Once that's in you should be able to use the locale filter for snippets using the new locale fields.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/snippets-service

https://github.com/mozilla/snippets-service/commit/95b9bb4c151ff03ffb45202c71eba952aa84803d
Fix bug 900287: Add filter by locale and template name to admin.

Admins have been having trouble filtering by locale, as they mistakenly
thought the old set of Client Match Rules would let them filter by 
locale. We're fixing this by adding the ability to filter by the real
locale field, and also adding the ability to filter by template so that
they can filter out old imported snippets during their searches.

Comment 3

[Jean Collings]

Hi Mike,
We are still seeing issues when we filter by locale. When filtering by locale, snippets not relevant to that locale shows up in the list and it is because there are thousands of snippets that have all the locales listed in the right hand box underneath "Chosen Locales" - such as this snippet: https://snippets.mozilla.com/admin/base/snippet/4074/

Is there a way to clean this up automatically for all the snippets that have that issue?

Comment 4

[Osmose [:osmose, :mkelly]]

Automatically, there aren't many good options, but what you can do is figure out what snippets you won't ever be using again, and delete them. Whatever is remaining we can go in and remove the client match rules and set the locales manually on them based on the rules they had, and the locale filter will work without an issue.

The short-term solution is to filter by template as well as locale, which will let you filter out snippets with the import template.

Does that help?