900289 - Enable foreign key pragma on FHR database

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Firefox Health Report Service, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This ensures correctness that is already assumed to exist and allows convenience functionality like cascading deletions.

More robust insertion tests may need to be added to ensure the DB data is properly inserted.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

r? - https://github.com/mozilla-services/android-sync/pull/342

Note that the PrepopulatedMockHealthReportDatabaseStorage class is a modified cherry-pick from https://github.com/mozilla-services/android-sync/pull/335 , the original on which you have already f+'d.

Comment 2

[Richard Newman [:rnewman]]

Reviewed.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

r? - Please provide additional feedback on the versioning (and XXX) change and https://github.com/mozilla-services/android-sync/pull/342#r5593766

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

> https://github.com/mozilla-services/android-sync/pull/342#r5593766

It seemed to eat my URL. This is for the comment on line 345 of TestHealthReportDatabaseStorage.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

r? (again) - added data migration and the associated tests. Please let me know if I'm being too diligent in testing.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

r+ via git.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/e881258c3ac5

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e881258c3ac5