Enable foreign key pragma on FHR database

RESOLVED FIXED

Status

Android Background Services
Firefox Health Report Service
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This ensures correctness that is already assumed to exist and allows convenience functionality like cascading deletions.

More robust insertion tests may need to be added to ensure the DB data is properly inserted.
(Assignee)

Updated

4 years ago
Assignee: nobody → michael.l.comella
OS: Linux → Android
Hardware: x86_64 → ARM
Status: NEW → ASSIGNED
Hardware: ARM → All
Whiteboard: [qa+]
(Assignee)

Comment 1

4 years ago
r? - https://github.com/mozilla-services/android-sync/pull/342

Note that the PrepopulatedMockHealthReportDatabaseStorage class is a modified cherry-pick from https://github.com/mozilla-services/android-sync/pull/335 , the original on which you have already f+'d.
Flags: needinfo?(rnewman)
Reviewed.
Flags: needinfo?(rnewman)
(Assignee)

Comment 3

4 years ago
r? - Please provide additional feedback on the versioning (and XXX) change and https://github.com/mozilla-services/android-sync/pull/342#r5593766
Flags: needinfo?(rnewman)
(Assignee)

Comment 4

4 years ago
> https://github.com/mozilla-services/android-sync/pull/342#r5593766

It seemed to eat my URL. This is for the comment on line 345 of TestHealthReportDatabaseStorage.
(Assignee)

Comment 5

4 years ago
r? (again) - added data migration and the associated tests. Please let me know if I'm being too diligent in testing.
(Assignee)

Comment 6

4 years ago
Created attachment 787942 [details] [diff] [review]
Patch

r+ via git.
Attachment #787942 - Flags: review+
Flags: needinfo?(rnewman)
(Assignee)

Comment 7

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/e881258c3ac5
https://hg.mozilla.org/mozilla-central/rev/e881258c3ac5
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.