This ensures correctness that is already assumed to exist and allows convenience functionality like cascading deletions. More robust insertion tests may need to be added to ensure the DB data is properly inserted.
r? - https://github.com/mozilla-services/android-sync/pull/342 Note that the PrepopulatedMockHealthReportDatabaseStorage class is a modified cherry-pick from https://github.com/mozilla-services/android-sync/pull/335 , the original on which you have already f+'d.
r? - Please provide additional feedback on the versioning (and XXX) change and https://github.com/mozilla-services/android-sync/pull/342#r5593766
> https://github.com/mozilla-services/android-sync/pull/342#r5593766 It seemed to eat my URL. This is for the comment on line 345 of TestHealthReportDatabaseStorage.
r? (again) - added data migration and the associated tests. Please let me know if I'm being too diligent in testing.
Created attachment 787942 [details] [diff] [review] Patch r+ via git.