900331 - [WAP Push] Add MSISDN to notification of WAP Push message

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

If MSISDN filter in bug 887156 is going to implemented by app, then the system message should bring MSISDN.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Provide sender in system message of WAP Push receiving.

Add sender in system message object.

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Provide MSISDN to WAP Push Manager. V2

After field test, it seems some carrier doesn't provide MSISDN in international number form.
Use phone number utility try to format MSISDN into international number form.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 787318 [details] [diff] [review]
0001. Provide MSISDN to WAP Push Manager. V2

Review of attachment 787318 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wappush/src/gonk/WapPushManager.js
@@ +112,5 @@
> +    let sender = PhoneNumberUtils.normalize(options.sourceAddress, false);
> +    let parsedSender = PhoneNumberUtils.parse(sender);
> +    if (parsedSender && parsedSender.internationalNumber) {
> +      sender = parsedSender.internationalNumber;
> +    }

This should have no effect on the problem you want to fix.  That is, "886123456789" will remain "886123456789" because current PhoneNumberUtils just won't recognize it as an international number.  See http://mxr.mozilla.org/mozilla-central/source/dom/phonenumberutils/PhoneNumber.jsm#328 , it has to be prefixed with either a plus sign or a international prefix, which in Taiwan is 0(0[25679]|19), before it can be parsed as an international number.

Let's just use your first patch.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 787318 [details] [diff] [review]
0001. Provide MSISDN to WAP Push Manager. V2

Review of attachment 787318 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wappush/src/gonk/WapPushManager.js
@@ +112,5 @@
> +    let sender = PhoneNumberUtils.normalize(options.sourceAddress, false);
> +    let parsedSender = PhoneNumberUtils.parse(sender);
> +    if (parsedSender && parsedSender.internationalNumber) {
> +      sender = parsedSender.internationalNumber;
> +    }

It works because |PhoneNumberUtils.parse()| provides default region for |PhoneNumberUtils.ParseNumber()|.

http://mxr.mozilla.org/mozilla-central/source/dom/phonenumberutils/PhoneNumberUtils.jsm#72

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 787318 [details] [diff] [review]
0001. Provide MSISDN to WAP Push Manager. V2

Review of attachment 787318 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, my brain is just not large enough to compile phonenumberutils on the fly.

Comment 6

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

try start:
https://tbpl.mozilla.org/?tree=Try&rev=c3480f2bd3c5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/685a2b619828

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/685a2b619828