the BMO push script shouldn't deploy if checksetup.pl failed

RESOLVED FIXED

Status

()

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: glob, Assigned: fubar)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
the BMO push script shouldn't deploy if checksetup.pl failed.
(Assignee)

Comment 1

5 years ago
Attaching a simple patch that should fix this; gogo pipefail.
(Assignee)

Comment 2

5 years ago
Created attachment 784599 [details] [diff] [review]
exit on checksetup.pl error
Attachment #784599 - Flags: review?(shyam)
Comment on attachment 784599 [details] [diff] [review]
exit on checksetup.pl error

Review of attachment 784599 [details] [diff] [review]:
-----------------------------------------------------------------

Looks straightforward enough. Do we want to unset pipefail (since that's the default). Want to make sure this won't cause unexpected fails elsewhere :)
Attachment #784599 - Flags: review?(shyam) → review+
(Assignee)

Comment 4

5 years ago
Since it's within the backticks (`...`) it only applies to that chain; that actually threw me off initially since it'd put it above in the main script and it wasn't having any effect.
(In reply to Kendall Libby [:fubar] from comment #4)
> Since it's within the backticks (`...`) it only applies to that chain; that
> actually threw me off initially since it'd put it above in the main script
> and it wasn't having any effect.

Those brackets are evil. I totally missed them too...
(Assignee)

Comment 6

5 years ago
As it happens, the prod script is slightly different than stage/dev and doesn't use backticks, so I added in an unset pipefail; the rest is the same. Committed in r72366.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Assignee: server-ops-webops → klibby
Component: WebOps: Bugzilla → Infrastructure
Product: Infrastructure & Operations → bugzilla.mozilla.org
You need to log in before you can comment on or make changes to this bug.