Closed
Bug 900573
Opened 8 years ago
Closed 8 years ago
Layout View now has black text
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: paul, Assigned: Optimizer)
References
Details
Attachments
(1 file)
2.16 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
This is a regression.
Assignee | ||
Comment 1•8 years ago
|
||
Turns out that actually no code change from any point of view. the same number of styles apply to the texts. The only difference is that the ordering of the CSS files that get applied is different now. Earlier the ordering was random : http://i.snag.gy/UEhyp.jpg and now it is sorted : http://i.snag.gy/LBahw.jpg I think the only thing we can do now is to add a !important to the color style in layout-view.jsm .
![]() |
||
Comment 2•8 years ago
|
||
Pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=82659e86fd98&tochange=ea93ffd484cf Triggered by Bug 897672. So, I think this is a intentional behavior.
Blocks: 897672
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Alice0775 White from comment #2) > Pushlog: > http://hg.mozilla.org/integration/fx-team/ > pushloghtml?fromchange=82659e86fd98&tochange=ea93ffd484cf > > Triggered by Bug 897672. So, I think this is a intentional behavior. Thanks Alice for finding it out! Indeed. It was broken-working previously, now it is fixed-broken! :P Adding !important is the only option here.
(In reply to Girish Sharma [:Optimizer] from comment #3) > (In reply to Alice0775 White from comment #2) > > Pushlog: > > http://hg.mozilla.org/integration/fx-team/ > > pushloghtml?fromchange=82659e86fd98&tochange=ea93ffd484cf > > > > Triggered by Bug 897672. So, I think this is a intentional behavior. > > Thanks Alice for finding it out! > > Indeed. It was broken-working previously, now it is fixed-broken! :P > > Adding !important is the only option here. I doubt that... surely we just need to increase the specificity.
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4) > I doubt that... surely we just need to increase the specificity. Sorry, I did not understand what you mean here ...
Assignee | ||
Comment 6•8 years ago
|
||
Fix.
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 784616 [details] [diff] [review] fix Increasing the specificity would work. But it's not worth it I think. !important works.
Attachment #784616 -
Flags: review?(paul) → review+
Assignee | ||
Comment 8•8 years ago
|
||
and moreover, I think the specificity was decreased on a purpose : re bug 879692
Assignee | ||
Comment 9•8 years ago
|
||
err. sorry. disregard my last comment.
Assignee | ||
Comment 10•8 years ago
|
||
landed in fx-team : https://hg.mozilla.org/integration/fx-team/rev/fee8d3cd387d
Whiteboard: [fixed-in-fx-team]
Comment 11•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fee8d3cd387d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Updated•3 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•