900573 - Layout View now has black text

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Paul Rouget [:paul]]

This is a regression.

Comment 1

[Girish Sharma [:Optimizer]]

Turns out that actually no code change from any point of view. the same number of styles apply to the texts. The only difference is that the ordering of the CSS files that get applied is different now.

Earlier the ordering was random : http://i.snag.gy/UEhyp.jpg
and now it is sorted : http://i.snag.gy/LBahw.jpg

I think the only thing we can do now is to add a !important to the color style in layout-view.jsm .

Comment 2

[Alice0775 White]

Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=82659e86fd98&tochange=ea93ffd484cf

Triggered by Bug 897672. So, I think this is a intentional behavior.

Comment 3

[Girish Sharma [:Optimizer]]

(In reply to Alice0775 White from comment #2)
> Pushlog:
> http://hg.mozilla.org/integration/fx-team/
> pushloghtml?fromchange=82659e86fd98&tochange=ea93ffd484cf
> 
> Triggered by Bug 897672. So, I think this is a intentional behavior.

Thanks Alice for finding it out!

Indeed. It was broken-working previously, now it is fixed-broken! :P

Adding !important is the only option here.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Girish Sharma [:Optimizer] from comment #3)
> (In reply to Alice0775 White from comment #2)
> > Pushlog:
> > http://hg.mozilla.org/integration/fx-team/
> > pushloghtml?fromchange=82659e86fd98&tochange=ea93ffd484cf
> > 
> > Triggered by Bug 897672. So, I think this is a intentional behavior.
> 
> Thanks Alice for finding it out!
> 
> Indeed. It was broken-working previously, now it is fixed-broken! :P
> 
> Adding !important is the only option here.

I doubt that... surely we just need to increase the specificity.

Comment 5

[Girish Sharma [:Optimizer]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> I doubt that... surely we just need to increase the specificity.

Sorry, I did not understand what you mean here ...

Comment 6

[Girish Sharma [:Optimizer]]

Attachment: fix

Fix.

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 784616 [details] [diff] [review]
fix

Increasing the specificity would work. But it's not worth it I think. !important works.

Comment 8

[Girish Sharma [:Optimizer]]

and moreover, I think the specificity was decreased on a purpose : re bug 879692

Comment 9

[Girish Sharma [:Optimizer]]

err. sorry. disregard my last comment.

Comment 10

[Girish Sharma [:Optimizer]]

landed in fx-team : https://hg.mozilla.org/integration/fx-team/rev/fee8d3cd387d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fee8d3cd387d