Closed
Bug 900626
Opened 11 years ago
Closed 11 years ago
Enable auto correction for Norsk Bokmål
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: luigitedone, Assigned: luigitedone)
References
Details
Attachments
(1 file, 1 obsolete file)
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:25.0) Gecko/20130726 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130726072540
Steps to reproduce:
Auto correction is not implemented for Norsk Bokmål
|
Assignee | |
Updated•11 years ago
|
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #784530 -
Flags: review?(dflanagan)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 784530 [details]
Proposed patch
><!DOCTYPE html>
><meta charset="utf-8">
><meta http-equiv="refresh" content="1;https://github.com/mozilla-b2g/gaia/pull/11301/">
><title>Bugzilla Code Review</title>
><p>Redirecting to <a href="https://github.com/mozilla-b2g/gaia/pull/11301/">» pull request on github</a></p>
Attachment #784530 -
Attachment mime type: text/plain → text/html
|
||
Comment 3•11 years ago
|
||
Hi Luigi, thanks for your patch! I'm reluctant to let this in after bug 884752 gets resolved, because we don't want the build size to be increased any more as we already have problems on some devices.
|
|
||
Updated•11 years ago
|
Attachment #784530 -
Flags: review?(dflanagan) → review?(janjongboom)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → luigitedone
|
|
||
Comment 4•11 years ago
|
||
Could you update this so it would merge again?
Flags: needinfo?(luigitedone)
|
|
Assignee | |
Comment 5•11 years ago
|
||
I did it, but I would prefer to land this one first: https://bugzilla.mozilla.org/show_bug.cgi?id=902120
Flags: needinfo?(luigitedone)
|
|
||
Comment 6•11 years ago
|
||
Alright.
|
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #784530 -
Attachment is obsolete: true
Attachment #784530 -
Flags: review?(janjongboom)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8341077 -
Flags: review?(janjongboom)
|
|
||
Comment 8•11 years ago
|
||
Comment on attachment 8341077 [details] [review]
Proposed patch
I can type Jeg vil ha en øl, which is the only thing I say in Norwegian, so I'm happy. r=me.
Attachment #8341077 -
Flags: review?(janjongboom) → review+
|
|
||
Comment 9•11 years ago
|
||
Please update the commit message to be in the form of
Bug 900626 - ...
$ git commit --amend -m "Bug 900626 - ..."
$ git push origin Bug_900626-Enable_auto_correction_for_Norsk_Bokmål_v2 -f
|
|
||
Updated•11 years ago
|
Flags: needinfo?(luigitedone)
|
|
||
Comment 11•11 years ago
|
||
Landed in https://github.com/mozilla-b2g/gaia/commit/78e10d3ea81a4799d8456b10db8178ce83cd55c0
Again thanks Luigi for picking this up :-)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•