Trace actor reports NaN time when exiting frames

RESOLVED FIXED in Firefox 25

Status

()

Firefox
Developer Tools
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Jake Bailey, Assigned: Jake Bailey)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 25
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

3.23 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
When exiting a frame, the trace actor reports that the time since the trace started is NaN. It should report the time in the same format as it does on frame entry (currently, milliseconds since tracing started).
(Assignee)

Updated

4 years ago
Assignee: nobody → rbailey
Blocks: 887024
(Assignee)

Comment 1

4 years ago
Created attachment 784698 [details] [diff] [review]
Patch
Attachment #784698 - Flags: review?(nfitzgerald)
(Assignee)

Updated

4 years ago
Attachment #784698 - Flags: review?(nfitzgerald)
(Assignee)

Comment 2

4 years ago
Created attachment 784702 [details] [diff] [review]
exitTime.diff

Whoops, generated the patch wrong.
Attachment #784698 - Attachment is obsolete: true
Attachment #784702 - Flags: review?(nfitzgerald)
Comment on attachment 784702 [details] [diff] [review]
exitTime.diff

Review of attachment 784702 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with green try push[0]

In the future, format your patches with 8 lines of context[1].

[0] https://wiki.mozilla.org/ReleaseEngineering/TryServer#How_to_push_to_try

[1] https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Attachment #784702 - Flags: review?(nfitzgerald) → review+
(Assignee)

Comment 4

4 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=97c8bc7f176b
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/24446c5f75c1
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/24446c5f75c1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.