900811 - Media Recording - Encoder fail to shutdown when closing the browser tab during recording a fake gUM

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Shelly Lin [:shelly]]

## STR ##
https://rawgithub.com/randylin/mediaRecorder/master/MediaRecorder.html
1. GetFakeUserMedia
2. Start recording
3. Close this tab

Observe:
The MediaEncoder thread does not shutdown.

Although the stream is "fake", but no harm to fix it.

Comment 1

[Jason Smith [:jsmith]]

Could this be a dupe of bug 894134? Or is this part of the reason why bug 894134 is happening?

Comment 2

[Shelly Lin [:shelly]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Could this be a dupe of bug 894134? Or is this part of the reason why bug
> 894134 is happening?

Were you testing bug 894134 with fake gUM? If so, I'm about to attach a fix patch.

Comment 3

[Shelly Lin [:shelly]]

Attachment: Handle the hang if closing the tab directly while recording fake gUM

Fixes are:
1. Moves the fix in bug 895730 to AudioTrackEncoder::NotifyEndOfStream(), to assure it will be called if MediaStream does not issue a NotifyRemoved().

2. If Cancel() is called, then don't bother creating the track encoder nor outputting the silence data.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Shelly Lin [:shelly] from comment #2)
> (In reply to Jason Smith [:jsmith] from comment #1)
> > Could this be a dupe of bug 894134? Or is this part of the reason why bug
> > 894134 is happening?
> 
> Were you testing bug 894134 with fake gUM? If so, I'm about to attach a fix
> patch.

Nah, not fake gUM. bug 894134 was tested with real audio in gUM.

It would be interesting to know if the issue being described here provides any benefit to real audio in gUM.

Comment 5

[Shelly Lin [:shelly]]

Try server result:
https://tbpl.mozilla.org/?tree=Try&rev=74302785a2a3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/9803634ed1f3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9803634ed1f3