Closed
Bug 900839
Opened 11 years ago
Closed 11 years ago
Remove unused variables in nsNativeThemeCocoa.mm
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
| Tracking | Status | |
|---|---|---|
| firefox24 | --- | unaffected |
| firefox25 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 2 open bugs)
Details
(Keywords: regression, Whiteboard: [qa-])
Attachments
(1 file)
|
982 bytes,
patch
|
dzbarsky
:
review+
|
Details | Diff | Splinter Review |
When bug 893117 removed nsIDOMHTMLMeterElement, the "unusedness" of the following local variables was revealed in these warnings: widget/cocoa/nsNativeThemeCocoa.mm:1408:10 [-Wunused-variable] unused variable 'low' widget/cocoa/nsNativeThemeCocoa.mm:1409:10 [-Wunused-variable] unused variable 'high' widget/cocoa/nsNativeThemeCocoa.mm:1410:10 [-Wunused-variable] unused variable 'optimum'
Attachment #784821 -
Flags: review?(bzbarsky)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 784821 [details] [diff] [review] remove-unused-variables.patch Review of attachment 784821 [details] [diff] [review]: ----------------------------------------------------------------- Stealing this.
Attachment #784821 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/32dc36c6af9f
Keywords: regression
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/32dc36c6af9f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Assuming no QA needed here. Please remove [qa-] from the whiteboard and add the verifyme keyword if this needs QA.
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•