900887 - Handle state change: "CALL_STATE_DIALING" -> "CALL_STATE_CONNECTED"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Eric Chou [:ericchou] [:echou]]

I tried to answer a phone call while a Bluetooth headset was connected, but I found that my Unagi would not send indicator "Call=1" even if the call has been picked up. 

The root cause is that Gecko Blueooth received the CallStateChanged event which indicates the phone call state was changed from 'CALL_STATE_DIALING' to 'CALL_STATE_CONNECTED'. This is not what we expected. The state should be changed as

  CALL_STATE_DIALING -> CALL_STATE_ALERTING -> CALL_STATE_CONNECTED

I've talked to RIL peer HsinYi, and she will help us to confirm RIL implementation and GSM spec.

Comment 1

[Eric Chou [:ericchou] [:echou]]

I'm sorry that I accidentally paste the wrong description above. Below is the correct description:

Based on bug 900882 comment 2, Gecko Bluetooth should handle call state change: CALL_STATE_DIALING -> CALL_STATE_CONNECTED, or the wrong state may confuse the user because of  the weird behavior of Bluetooth headset like the unreasonable LED flashing.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Nominate as leo+ since it would be very likely to happen on b2g18. Additionally, the solution won't be too complicated, so it should be harmless.

Comment 3

[Ben Tian (inactive)]

Attachment: Patch 1: v1: Handle call state DIALING -> CONNECTED

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 785614 [details] [diff] [review]
Patch 1: v1: Handle call state DIALING -> CONNECTED

Review of attachment 785614 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Please note that this patch is m-c only, which means that it's not compatible with b2g18 codebase. We will need another patch if this bug becomes leo+ afterwards.

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/981444a82ce0

Comment 6

[Wayne Chang [:wchang]]

Triage - leo+ as likely required for BT accessories to function correctly.

Comment 7

[Ben Tian (inactive)]

Attachment: [final] Patch 1 (b2g18 only): Handle call state DIALING -> CONNECTED

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/981444a82ce0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/43a00244c61e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/43a00244c61e

Comment 11

[Jeni]

Verified fixed on 

Build ID: 20130814041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/15813d776a69
Gaia: dd3959fa74e356a528daa76ffee14c2c728a4b56
Platform Version: 18.1
RIL Version: 01.01.00.019.190 

User is able to answer phone call with Bluetooth successfully and no strange indicators shown