Closed
Bug 900901
Opened 11 years ago
Closed 11 years ago
[Keyboard] Replace the pinyin IME engine with the emscripten'ed one
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)
Tracking
(blocking-b2g:koi+, b2g-v1.2 fixed)
People
(Reporter: lchang, Assigned: lchang)
References
Details
(Whiteboard: [ucid:SystemPlatform17], [FT: System Platform], [Sprint: 2])
Attachments
(1 file)
Since emscripten'ed pinyin engine can get better performance and lower memory consumption than current one, it is recommended that replace the pinyin IME engine to emscripten'ed version.
Comment 1•11 years ago
|
||
Add keyword in whiteboard for tracking it in system platform agile team
blocking-b2g: --- → koi?
Whiteboard: [ucid:SystemPlatform17], [FT: System Platform], [Sprint: 2]
Updated•11 years ago
|
Priority: -- → P1
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → lchang
Assignee | ||
Comment 2•11 years ago
|
||
I'll file a new bug for adding an instruction about the Emscripten compiling steps.
Attachment #790038 -
Flags: review?(timdream)
Attachment #790038 -
Flags: review?(rlu)
Comment 3•11 years ago
|
||
Comment on attachment 790038 [details]
pull request
Great job! Let's make sure the code is maintainable in the long run by addressing the following follow-up issues:
-- In the source C repo, write a Makefile with instructions to build the exact code in Gaia.
-- Put everything in Web Workers so that we would not pollute the global in keyboard app.
Attachment #790038 -
Flags: review?(timdream) → review+
Comment 4•11 years ago
|
||
Comment on attachment 790038 [details]
pull request
r+, though I guess we still need a basic documentation on how to generate the emscripten'ed version of the pinyin lib.
Thanks.
Attachment #790038 -
Flags: review?(rlu) → review+
Assignee | ||
Comment 5•11 years ago
|
||
I've updated my pull request with a brief instruction about how to compile emscripten'ed library. Thanks Rudy and Tim.
Comment 6•11 years ago
|
||
Merged to Gaia master, https://github.com/mozilla-b2g/gaia/commit/2cad0ff0180e0b33ac49aed3030949e6edbda95d Luke, thanks for working on this, great job!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: koi? → koi+
status-b2g-v1.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•