Closed Bug 900930 Opened 6 years ago Closed 6 years ago
Splinter shouldn't choke on patches which have had trailing whitespace removed
Compare https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=889717&attachment=784887 with https://bugzilla.mozilla.org/attachment.cgi?id=784887&action=diff. I think this is a pretty major flaw as it prevents thorough reviews.
that patch has had all trailing whitespace removed from it, which makes it technically an invalid patch. the issue is the empty lines within the hunks - they should contain a single space. splinter and diff take radically different approaches when it comes to parsing patches, resulting in variations when patches are not strictly valid. diff takes a line-by-line approach, honouring the line counts on the @@ line, while splinter using a collection of regexs to split up the file. as this comes up a bit, i'll see if i can convince splinter's regex to treat an empty line as a line containing a single space.
Assignee: nobody → glob
Severity: major → normal
Summary: Splinter doesn't show all the diff → Splinter shouldn't choke on patches which have had trailing whitespace removed
this should do it.. Committing to: bzr+ssh://email@example.com/bmo/4.2/ modified extensions/Splinter/web/splinter.js Committed revision 8961.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.