900930 - Splinter shouldn't choke on patches which have had trailing whitespace removed

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Splinter, defect)

Description

[Anthony Ricaud (:rik)]

Compare https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=889717&attachment=784887 with https://bugzilla.mozilla.org/attachment.cgi?id=784887&action=diff.

I think this is a pretty major flaw as it prevents thorough reviews.

Comment 1

[:glob ✱]

that patch has had all trailing whitespace removed from it, which makes it technically an invalid patch.  the issue is the empty lines within the hunks - they should contain a single space.

splinter and diff take radically different approaches when it comes to parsing patches, resulting in variations when patches are not strictly valid.  diff takes a line-by-line approach, honouring the line counts on the @@ line, while splinter using a collection of regexs to split up the file.

as this comes up a bit, i'll see if i can convince splinter's regex to treat an empty line as a line containing a single space.

Comment 2

[:glob ✱]

this should do it..

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Splinter/web/splinter.js
Committed revision 8961.