Closed
Bug 900933
Opened 12 years ago
Closed 12 years ago
Alarm API - AlarmsManager.remove() should use sendAsyncMessage()
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: airpingu, Assigned: airpingu)
References
Details
Attachments
(1 file)
|
2.70 KB,
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
First of all, .remove() should return nothing according the spec. Secondly, we shouldn't wait for the return of sendSyncMessage, where the remove is actually performing asynchronous DB interaction.
[1] https://developer.mozilla.org/en-US/docs/Web/API/MozAlarmsManager.remove
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #784952 -
Flags: review?(nsm.nikhil)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 784952 [details] [diff] [review]
Patch
Review of attachment 784952 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/alarm/AlarmsManager.js
@@ +92,1 @@
> "AlarmsManager:Remove",
Nit: Can you remove the trailing whitespace.
Attachment #784952 -
Flags: review?(nsm.nikhil) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Fixed trailing white space and land the patch.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1387a91ce0bc
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•