900960 - Enable the new Notification API on B2G by default

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Julien Wajsberg [:julienw]]

in Bug 782211 (commit is http://hg.mozilla.org/mozilla-central/rev/dde6b08c74f7) the new Notification API was set to false for some reason.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: 900960-enable-webnotification.patch

Comment 2

[Julien Wajsberg [:julienw]]

try is https://tbpl.mozilla.org/?tree=Try&rev=b7c79aa55dfe

Comment 3

[Julien Wajsberg [:julienw]]

cc mike so that he knows about this

Comment 4

[Julien Wajsberg [:julienw]]

btw Mike feel free to take this as part of another bug if you like.

Comment 5

[Julien Wajsberg [:julienw]]

Tried with http://everlong.org/mozilla/notifications/ and it crashes. (it works perfectly in Android).

(note: you need to try the patch with a gecko before bug 866232 to be able to press the button).

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 784998 [details] [diff] [review]
900960-enable-webnotification.patch

Moving forward, will file another bug for the crash

Comment 7

[Gregor Wagner [:gwagner]]

Do we have an idea how many things break if we land it?

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Gregor Wagner [:gwagner] from comment #7)
> Do we have an idea how many things break if we land it?

The old one is still turned on and I think the 2 notifications impl takes different code paths so that should be fine.

Comment 9

[Julien Wajsberg [:julienw]]

Gregor will finish and land this.

Comment 10

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/06aecc131ac6

Comment 11

[Julien Wajsberg [:julienw]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #8)
> (In reply to Gregor Wagner [:gwagner] from comment #7)
> > Do we have an idea how many things break if we land it?
> 
> The old one is still turned on and I think the 2 notifications impl takes
> different code paths so that should be fine.

The gaia system code and the b2g shell.js code are the same for both notifications impl, but the messages should work together.

Anyway, my tests showed that the old notification API still works fine.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06aecc131ac6

Comment 13

[Jason Smith [:jsmith]]

Verified on master 9/11 build - confirmed this is preffed on by default.