Closed Bug 900960 Opened 11 years ago Closed 11 years ago

Enable the new Notification API on B2G by default

Categories

(Core :: DOM: Core & HTML, defect)

22 Branch
ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla26
blocking-b2g koi+
Tracking Status
firefox26 --- fixed

People

(Reporter: julienw, Assigned: gwagner)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

in Bug 782211 (commit is http://hg.mozilla.org/mozilla-central/rev/dde6b08c74f7) the new Notification API was set to false for some reason.
Assignee: nobody → felash
cc mike so that he knows about this
btw Mike feel free to take this as part of another bug if you like.
Tried with http://everlong.org/mozilla/notifications/ and it crashes. (it works perfectly in Android). (note: you need to try the patch with a gecko before bug 866232 to be able to press the button).
Comment on attachment 784998 [details] [diff] [review] 900960-enable-webnotification.patch Moving forward, will file another bug for the crash
Attachment #784998 - Flags: review?(fabrice)
Blocks: 892528
Do we have an idea how many things break if we land it?
(In reply to Gregor Wagner [:gwagner] from comment #7) > Do we have an idea how many things break if we land it? The old one is still turned on and I think the 2 notifications impl takes different code paths so that should be fine.
Gregor will finish and land this.
Assignee: felash → anygregor
(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #8) > (In reply to Gregor Wagner [:gwagner] from comment #7) > > Do we have an idea how many things break if we land it? > > The old one is still turned on and I think the 2 notifications impl takes > different code paths so that should be fine. The gaia system code and the b2g shell.js code are the same for both notifications impl, but the messages should work together. Anyway, my tests showed that the old notification API still works fine.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Verified on master 9/11 build - confirmed this is preffed on by default.
Status: RESOLVED → VERIFIED
Whiteboard: [systemsfe]
blocking-b2g: koi? → koi+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: