Closed Bug 900986 Opened 7 years ago Closed 6 years ago

Convert JS_*Element API to use MutableHandleValue for out params

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jonco, Assigned: jonco)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Continues the work of converting jsval* out params to MutableHandleValue in the JS API.
Attached patch element-api-mhvSplinter Review
JS engine changes
Attachment #785031 - Flags: review?(terrence)
PConnect changes
Attachment #785032 - Flags: review?(bobbyholley+bmo)
Changes in the rest of the browser
Attachment #785033 - Flags: review?(bugs)
Attachment #785032 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 785033 [details] [diff] [review]
element-api-mhv-browser

JS_SetElement is odd method. inout params aren't nice.
But that issue is not about this bug.

r=me
Attachment #785033 - Flags: review?(bugs) → review+
Comment on attachment 785031 [details] [diff] [review]
element-api-mhv

Review of attachment 785031 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #785031 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/c9384a37f165
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Blocks: 773686
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.