Closed
Bug 900986
Opened 11 years ago
Closed 11 years ago
Convert JS_*Element API to use MutableHandleValue for out params
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
|
20.50 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
|
6.88 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
|
36.04 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Continues the work of converting jsval* out params to MutableHandleValue in the JS API.
|
Assignee | |
Comment 2•11 years ago
|
||
PConnect changes
Attachment #785032 -
Flags: review?(bobbyholley+bmo)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Changes in the rest of the browser
Attachment #785033 -
Flags: review?(bugs)
|
||
Updated•11 years ago
|
Attachment #785032 -
Flags: review?(bobbyholley+bmo) → review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 785033 [details] [diff] [review] element-api-mhv-browser JS_SetElement is odd method. inout params aren't nice. But that issue is not about this bug. r=me
Attachment #785033 -
Flags: review?(bugs) → review+
|
||
Comment 5•11 years ago
|
||
Comment on attachment 785031 [details] [diff] [review] element-api-mhv Review of attachment 785031 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #785031 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9384a37f165
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c9384a37f165
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
|
Assignee | |
Updated•11 years ago
|
Blocks: 773686
Keywords: dev-doc-needed
|
||
Comment 8•9 years ago
|
||
JSAPI docs got updated a while ago and I think this change is covered (thanks :arai!): https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_ForwardGetPropertyTo https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetElement https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_SetElement https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_LookupElement JS_GetElementIfPresent seems to be gone by now, it is not on MDN either. Technical review appreciated.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•