900989 - The size of homescreen page force excessive repaints

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

It seems like the size of page element on the homescreen force conflict with the translucent bottom bar and result into an excessive repaint of the bottom bar even if nothing has changed there.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug900989.wip.patch

The above fix the excessive repaints. It does not interact very well with everything.me though.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Asking koi? for performance bug on the homescreen

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: excessive.repaints.patch

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

leo? since there are apparently more repaints with e.me on the landing page...

The current version interact well with e.me.

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: excessive.repaints.patch

Patch approved.
Only changed the redundant calc(100%) to 100%.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 787578 [details] [diff] [review]
excessive.repaints.patch

Carrying r+.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/fdc7a16c49c0673c99935ffd091c5ba1218ea3d3

Comment 8

[Preeti Raghunath(:Preeti)]

Hi Vivien,

Can you please confirm the following:

1) Is this bug a regression in 1.1
2) What is the risk of the patch?
3) What is the impact to customers, if the patch is not taken?

Comment 9

[Wayne Chang [:wchang]]

Triage - partner has not made a decision on taking bug 838634 yet.

Leaving this bug decision to Moz triage after following up with comment 8. However, this blocks bug 838634, which has been leo+'ed.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Preeti Raghunath(:Preeti) from comment #8)
> Hi Vivien,
> 
> Can you please confirm the following:
> 
> 1) Is this bug a regression in 1.1

Since bug 838634 has landed on 1.1 and the e.me page is on the landing page, yes it is a panning regression between the landing page and the first app page in the homescreen.

> 2) What is the risk of the patch?

Poor user experience when using everything.me and try to escape to an other apps page.

> 3) What is the impact to customers, if the patch is not taken?

Could be that some partners does not want to ship the phone with this and then there won't be phone on the market ? :)

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

Paris Triage: leo+ to improve performance while changes are minimal

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This has landed on v1-train.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: c4212320b9914ea2819214cda58f908c7e8b1748

Comment 14

[Jeni]

Verified fixed on Leo

Build ID: 20130815041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12
Gaia: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
Platform Version: 18.1
RIL Version: 01.01.00.019.190 

size of page element on the homescreen no longer force conflict with the translucent bottom bar