901018 - [Clock] JavaScript Error: "minute is undefined" when creating alarm when time is minutes 0-9

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Zac C (:zac)]

Attachment: clock_minute_undef.log

We have intermittent failures in our alarm clock tests.

The automated test goes into clock app, creates an alarm, changes settings like repeat/sound/etc (but not changing the time) and then clicks 'Done'.

The affect in the UI is that no banner is shown and no error message is shown to the user that the alarm has failed to be created.

This logcat error message occurs after clicking 'Done' (line 877).

E/GeckoConsole( 1920): [JavaScript Error: "minute is undefined" {file: "app://clock.gaiamobile.org/gaia_build_defer_index.js" line: 173}]

This has only shown up in today's build:
Gecko  http://hg.mozilla.org/mozilla-central/rev/c489af94ada5
Gaia  4b347e4e39b1716b68463dccc63c1b3eb49158b3
BuildID 20130802070203
Version 25.0a1

Comment 1

[Jason Smith [:jsmith]]

Smoketest regression in the productivity's team ball court.

Dylan - Can you help find an assignee here to resolve this smoketest regression?

Comment 2

[Chris Kreinbring [:CKreinbring]]

Unable to repro after multiple attempts on Unagi 1.2 mozilla RIL.

Build ID: 20130802070203
Gecko: http://hg.mozilla.org/mozilla-central/rev/c489af94ada5
Gaia: 4b347e4e39b1716b68463dccc63c1b3eb49158b3
Platform Version: 25.0a1

Comment 3

[Zac C (:zac)]

This is an automated test result so you'd have difficulty either with the speed of the test or enough samples to replicate the intermittency.

Just looking at the source js, there is a lot of initialisation of these fields *after* the transition. In the automated test we are waiting for the css transition to complete so it's possible that the transition is completing before the fields are initialised.

Comment 4

[[e-mail], [e-mail]]

(In reply to Zac C (:zac) from comment #0)
> Created attachment 785075 [details]
> clock_minute_undef.log
> 
> We have intermittent failures in our alarm clock tests.
> 
> The automated test goes into clock app, creates an alarm, changes settings
> like repeat/sound/etc (but not changing the time) and then clicks 'Done'.
> 
> The affect in the UI is that no banner is shown and no error message is
> shown to the user that the alarm has failed to be created.
> 
> This logcat error message occurs after clicking 'Done' (line 877).
> 
> E/GeckoConsole( 1920): [JavaScript Error: "minute is undefined" {file:
> "app://clock.gaiamobile.org/gaia_build_defer_index.js" line: 173}]
> 
I have met the issue before in gaia/master. The root cause is the format of time picker. We have to give a correct format to the time picker when init the time.
You could reference the fixed patch. Hoping it is useful for automated test.
https://github.com/mozilla-b2g/gaia/commit/da0d6970cdb32c18e51384219c0d4e7b6d39a452

Comment 5

[Zac C (:zac)]

Hi Ian, I have found the bug properly now. It occurs when the time is at minute 0-9.

The bug is in the AlarmEdit.getTimeSelect() function. I verified this by calling it with Marionette script, which caused an exception. At the same time I could reliably replicate the automated test failure.
https://github.com/mozilla-b2g/gaia/blob/master/apps/clock/js/alarm_edit.js#L244


ckreinbring, you can replicate manually if you wait or set the phone's time to :00 - :09.

Escalating this because it is replicable manually.

Comment 6

[Jason Smith [:jsmith]]

This is a bad regression, but not a smoketest blocker.

Comment 7

[Tony Chung [:tchung]]

koi+

Comment 8

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request 11574.html

Rudy,

Could you please help to review my pr? 
It's relative with correct format of time picker.
Thanks.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 791228 [details]
Pointer to Github pull request 11574.html

r=me.
Thanks.

Comment 10

[Rick Waldron [:rwaldron]]

(In reply to Rudy Lu [:rudyl] from comment #9)
> Comment on attachment 791228 [details]
> Pointer to Github pull request 11574.html
> 
> r=me.
> Thanks.

Why "r"? There are no tests included in the patch.

Comment 11

[[e-mail], [e-mail]]

Comment on attachment 791228 [details]
Pointer to Github pull request 11574.html

Add unit test for function initTimeSelect().

Rudy,

Could you help to review the pr with unit test? Thanks.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11574/commits

Pointer to Github pull-request

Comment 13

[[e-mail], [e-mail]]

Comment on attachment 792036 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11574/commits

Set Rick to be reviewer.

Rick,

Could you please help to review the pr with unit test? Thanks.

Comment 14

[Rick Waldron [:rwaldron]]

Comment on attachment 792036 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11574/commits

r=me

Thanks Ian!

Comment 15

[[e-mail], [e-mail]]

Thanks for Rick's reviewing effort. Since the pr is merged, we can close the issue now.

gaia/master: 
https://github.com/mozilla-b2g/gaia/commit/0e27479d1bed100ffcfdc8412617e171bcbdb66c

Comment 16

[[e-mail], [e-mail]]

Comment on attachment 791228 [details]
Pointer to Github pull request 11574.html

Since Rick helped to review, I clean the review flag for Rudy.

Comment 17

[Peter Bylenga [:PBylenga]]

Verified Fixed: User is able to create and trigger an alarm set for 12:01 am thru 12:09 am.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131105004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/3ba912717904
Gaia: be4ea00a50236b10eb0a03232a28ffd0048e0cb8
Platform Version: 26.0
RIL Version: 01.01.00.019.281 
Firmware Version: US_20131015