901041 - Remove 'swipe left' screen in tutorial (as part of the first run experience)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Chris Lee [:clee]]

With the change in moving the app search bar to the Home Screen landing page, the team has agreed to remove the 'swipe left to discover new apps' in the Tutorial which is at the end of the First-Run experience.  

Will attach the screenshot shortly.

Comment 1

[Chris Lee [:clee]]

Marking leo+ and will request all partners to pick this up for v1.1.

Comment 3

[Fernando Campo (:fcampo)]

As this modification implies changes in l10n strings, maybe we would rather other options. What would be the best option for all, when we are this late in the game?

1. step2 disappears, step3 becomes step2, 4 becomes 3, 5 becomes 4. That would mean that we change the strings to something like 
  tutorial-step1, 
  tutorial-step2-2, 
  tutorial-step3-2, 
  tutorial-step4-2

2. we simply skip step2, jumping from 1 to 3, we don't make changes in the strings (apart from deleting the useless one), but there's an obvious jump in the steps (not noticeable for the user, but would make code look weird)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Fernando Campo (:fcampo) from comment #3)
> As this modification implies changes in l10n strings, maybe we would rather
> other options. What would be the best option for all, when we are this late
> in the game?
> 
> 1. step2 disappears, step3 becomes step2, 4 becomes 3, 5 becomes 4. That
> would mean that we change the strings to something like 
>   tutorial-step1, 
>   tutorial-step2-2, 
>   tutorial-step3-2, 
>   tutorial-step4-2
> 

tutorial-step4-3 right?

I think I would buy option 1. I'm way more scared of having an exception in the logic that removing one step.

Comment 5

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/11344

patch v1, eliminates the 2nd step of tutorial

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 785732 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/11344

We should not re-ID strings for this, in particular not for v1-train, i.e., for for option 2.

Note, if the names had originally been semantic, we'd not have this problem. Like "hold-delete" instead of "3". That'd be candy for a follow-up, and out of scope for v1-train.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Fernando do you really need to change any strings or can't you simply change the key attribute in the js file to point to the corresponding key. This can be changed later if you want a more semantic stuff...

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #7)
> Fernando do you really need to change any strings or can't you simply change
> the key attribute in the js file to point to the corresponding key. This can
> be changed later if you want a more semantic stuff...

Ping?

Comment 9

[Fernando Campo (:fcampo)]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #8)
> (In reply to Vivien Nicolas (:vingtetun) (:21) from comment #7)
> > Fernando do you really need to change any strings or can't you simply change
> > the key attribute in the js file to point to the corresponding key. This can
> > be changed later if you want a more semantic stuff...
> 
> Ping?

Sorry, I got caught up in other things and slipped my mind. 

And as an answer...no, we don't need to change the strings. I can just make the step to point at a different string without modifying any.
I guess that with a comment on the code to not forget about it on future releases (when we are not string-frozen)

Updating the PR and asking for review again

Comment 10

[Fernando Campo (:fcampo)]

Comment on attachment 785732 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/11344

Taking out Pike from review as this have no more changes to l10n (welcomed for feedback)
Asking for review again as the patch has changed, putting vivien as he has following the thread (redirect if you think francisco is better)

Comment 11

[Fernando Campo (:fcampo)]

Opened bug 902487 as a followup for changes on strings

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 785732 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/11344

Thanks for the quick update.

And I agree that the situation is not ideal for such type of changes! It can be fixed in a followup for 1.2 though.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/3db40fdea9d5d73006d889aff3c388d6bcaeaafb

Comment 14

[Preeti Raghunath(:Preeti)]

Chris,

Based on comment 1 you wanted this in 1.1.

Comment 12 is suggesting fixing it in 1.2.

Please confirm if clearly if this will be an issue for product team.

Comment 15

[Axel Hecht [:Pike]]

Stealing that needinfo:

We want the current patch in 1.1.

There's opportunity to refactor the code to not hard code which tutorial step is the 5th, making the maintenance of the code easier. That's for 1.2 or later.

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

v1-train:
https://github.com/mozilla-b2g/gaia/commit/8745c102acf9fa51f05b3d582af1132ca7f58cd9

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 8745c102acf9fa51f05b3d582af1132ca7f58cd9

Comment 18

[Montoya Clemmons (MClemmons)]

On latest build, confirmed swipe left in tutorial has been removed from First Run Experience. 

Environmental Variables
Build ID: 20130813041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/36bbc5943448
Gaia: df57dcec720493bedff4601499d78c147ad7d253
Platform Version: 18.1
RIL Version: 01.01.00.019.190 
Firmware Version: D300f08o