Closed Bug 901044 Opened 11 years ago Closed 11 years ago

Everything.me needs additional strings for the search bar

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

(Keywords: late-l10n, Whiteboard: QARegressExclude)

Attachments

(1 file)

This will help bug 838634 to get localization early (will save one week end...)
Keywords: late-l10n
Needed for v1.1, leo+'ing now.
blocking-b2g: leo? → leo+
Comment on attachment 785125 [details] [diff] [review]
bug838634.locales.patch

Review of attachment 785125 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK to me. I'm not sure about the "I'm thinking of ..." on a world-wide scope, but that's not our problem today.

::: apps/homescreen/locales/homescreen.en-US.properties
@@ +32,5 @@
>  evme-searchbar-default=Everything…
>  evme-searchbar-clear=Back
>  
> +evme-smart-folders=Smart Collections
> +evme-searchbar-default.placeholder=I'm thinking of…

I'm not sure if this will work across cultures, but for the localizations in 1.1 scope, it's probably going to have some match
Attachment #785125 - Flags: review?(l10n) → review+
Setting branch status flags
v1.1.0hd: 45f6a739b09292e16717fb21003386c914ca29c2
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: