Closed
Bug 901044
Opened 11 years ago
Closed 11 years ago
Everything.me needs additional strings for the search bar
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Firefox OS Graveyard
Gaia::Homescreen
Tracking
(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)
RESOLVED
FIXED
blocking-b2g | leo+ |
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
(Keywords: late-l10n, Whiteboard: QARegressExclude)
Attachments
(1 file)
1.61 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
This will help bug 838634 to get localization early (will save one week end...)
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → 21
Attachment #785125 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #785125 -
Flags: review? → review?(l10n)
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → leo?
Comment 3•11 years ago
|
||
Comment on attachment 785125 [details] [diff] [review]
bug838634.locales.patch
Review of attachment 785125 [details] [diff] [review]:
-----------------------------------------------------------------
Looks OK to me. I'm not sure about the "I'm thinking of ..." on a world-wide scope, but that's not our problem today.
::: apps/homescreen/locales/homescreen.en-US.properties
@@ +32,5 @@
> evme-searchbar-default=Everything…
> evme-searchbar-clear=Back
>
> +evme-smart-folders=Smart Collections
> +evme-searchbar-default.placeholder=I'm thinking of…
I'm not sure if this will work across cultures, but for the localizations in 1.1 scope, it's probably going to have some match
Attachment #785125 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 4•11 years ago
|
||
master:
https://github.com/mozilla-b2g/gaia/commit/1dee1df28df02e3d4abc24c2a275ca25b080181d
v1-train:
https://github.com/mozilla-b2g/gaia/commit/45f6a739b09292e16717fb21003386c914ca29c2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
v1.1.0hd: 45f6a739b09292e16717fb21003386c914ca29c2
status-b2g-v1.1hd:
--- → fixed
Updated•11 years ago
|
Whiteboard: QARegressExclude
You need to log in
before you can comment on or make changes to this bug.
Description
•