901064 - TopBookmarksView shows a divider during startup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Sriram Ramasubramanian [:sriram]]

The padding in the TopBookmarksView makes it have a default minimum size, which makes the enclosing list view show a divider. Kill it.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Comment 2

[:Margaret Leibovic]

Comment on attachment 785133 [details] [diff] [review]
Patch

Review of attachment 785133 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/TopBookmarksView.java
@@ +152,3 @@
>  
> +        if (adapter == null || (count = adapter.getCount()) == 0) {
> +            setMeasuredDimension(0, 0);

Add a comment about why we're doing this.

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/projects/fig/rev/d51f4bd67608

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d51f4bd67608