901098 - Trace actor "callsite" trace type actually returns source location

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jake Bailey]

The trace actor has a "callsite" trace type, but it returns the current position in execution, i.e. the first character of the executing function. There should be a separate "location" trace type for source location, and "callsite" should return the actual call site of the executing function.

Comment 1

[Jake Bailey]

Attachment: Patch

Comment 2

[Jake Bailey]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=1dbf0a1bc93c

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 785182 [details] [diff] [review]
Patch

Review of attachment 785182 [details] [diff] [review]:
-----------------------------------------------------------------

Can you file a follow up to use Debugger.Script.prototype.startLine and Debugger.Script.prototype.startColumn (which doesn't exist yet, so file a bug for it please) instead of the line/col of the frame?

::: toolkit/devtools/server/tests/unit/test_trace_actor-05.js
@@ +85,5 @@
> +      do_check_eq(typeof packets[1].callsite.column, "number",
> +                  'anonymous function callsite should have column');
> +      do_check_true(!isNaN(packets[1].callsite.column),
> +                    'anonymous function callsite column should be a number');
> +

Can we do better than just checking that line and column are numbers? Can we actually check that these things are the callsite vs definition location so that we don't repeat this regression?

Comment 4

[Jake Bailey]

Attachment: Patch

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/290389a3cbe7

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/290389a3cbe7