901278 - Xcode5-DPx/Xcode5 not recognized by bootstrap.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Josiah Bruner [:jsbruner]]

The bootstrap script does not check for Xcode-DPx (where x is some DP version). Because of this the bootstrap script will stop and force you to either change Xcode-DPx's name to Xcode or download the normal Xcode. This is especially a problem on the developer preview of Mavericks, since the old Xcode is not even allowed to be installed.

We should allow bootstrap to use Xcode-DPx as long as it is in the Applications directory.

Comment 1

[Josiah Bruner [:jsbruner]]

Correction, this is about "Xcode5-DPx" and "Xcode5". I'm guessing the Xcode5 is the real issue.

Comment 2

[Gregory Szorc [:gps]]

Can you please provide the necessary context to fix this? e.g. what are the actual directory names and/or version numbers? Can you provide the output from the bootstrapper demonstrating the error?

Comment 3

[Josiah Bruner [:jsbruner]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Can you please provide the necessary context to fix this? e.g. what are the
> actual directory names and/or version numbers? Can you provide the output
> from the bootstrapper demonstrating the error?

In /Applications/ there is a Xcode5-DP4.app. Command line tools have been installed.

I run the boostrap command in ~/Development/Mozilla/. I can't remember the exact output and can't test it currently since I'm on a different machine right now, but it was something along the lines of:

"Xcode not installed

 Xcode is required to build Firefox, please install Xcode and try again"

or something like that. It opens up Xcode in the Mac App Store, but it won't install on Mavericks.

This is on OS X 10.9 DP 4. Though it happens on every DP version.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

You have to run xcode-select -p /Applications/Xcode5-DPX.app first. Then the right paths and aliases have been setup and the script finds Xcode just fine.

Comment 5

[Josiah Bruner [:jsbruner]]

(In reply to Stefan Arentz [:st3fan] from comment #4)
> You have to run xcode-select -p /Applications/Xcode5-DPX.app first. Then the
> right paths and aliases have been setup and the script finds Xcode just fine.

Ah, cool. Forgot about that. Thanks. Marking as RESOLVED.

Comment 6

[Gregory Szorc [:gps]]

I installed Mavericks and encountered this issue. Might as well fix it.

Comment 7

[Gregory Szorc [:gps]]

Attachment: More intelligently detect installed Xcode

I installed a developer preview of Mavericks and was able to reproduce
this bug. This patch appears to fix it for me.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

Note that, in my (rather limited) experience, xcode-select --print-path *always* returns incorrect information on OS X 10.9 until xcode-select --switch has been run at least once.

If I remember right, this incorrect information is /Library/Developer/CommandLineTools.

Comment 9

[Gregory Szorc [:gps]]

(In reply to Steven Michaud from comment #8)
> Note that, in my (rather limited) experience, xcode-select --print-path
> *always* returns incorrect information on OS X 10.9 until xcode-select
> --switch has been run at least once.
> 
> If I remember right, this incorrect information is
> /Library/Developer/CommandLineTools.

That's why I check for ".app/" in the returned path :)

Comment 10

[Michael Shal [:mshal]]

Comment on attachment 805611 [details] [diff] [review]
More intelligently detect installed Xcode

Looks good!

Comment 11

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f05d9623c6d3

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f05d9623c6d3

Comment 13

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Just a quick not that OS X 10.9 GM was released together with Xcode 5.0.1 GM. The latter is now simply named 'Xcode.app' and the 'installer' encourages you to drag it to /Applications/ .. so there should be no special cases or checks needed.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/ac19638c4429
https://hg.mozilla.org/releases/mozilla-esr24/rev/0702935ee38e