Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements

RESOLVED FIXED in mozilla30

Status

()

Core
HTML: Parser
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Michael[tm] Smith, Assigned: wchen)

Tracking

Trunk
mozilla30
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(hsivonen)
(Reporter)

Comment 1

5 years ago
http://lists.w3.org/Archives/Public/public-html/2013Aug/0002.html from Travis Leithead seems to indicate that at this point Microsoft is inclined to implement the spec change.
See also bug 884795 which resulted in another change to the AAA:
   http://html5.org/tools/web-apps-tracker?from=8138&to=8139
   https://www.w3.org/Bugs/Public/show_bug.cgi?id=22926

It makes conforming pages parse correctly (before, if you nested multiple identical formatting elements more than 3 deep, you'd end up corrupting your tree; that was only supposed to happen when the document was non-conforming).
(Assignee)

Updated

4 years ago
Assignee: nobody → wchen
(Assignee)

Comment 3

4 years ago
Created attachment 8382844 [details] [diff] [review]
Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements

http://html5.org/r/8108
Attachment #8382844 - Flags: review?(hsivonen)
Comment on attachment 8382844 [details] [diff] [review]
Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements

r+, but instead of 

for (int j = 1; true; ++j) {

I'd prefer

int j = 0;
for (;;) {
  ++j;
  ...
}

to make the structure of the code match the structure of the spec more closely.
Attachment #8382844 - Flags: review?(hsivonen) → review+
Flags: needinfo?(hsivonen)
https://hg.mozilla.org/mozilla-central/rev/c04e2e2b2944
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 982285
You need to log in before you can comment on or make changes to this bug.