901341 - Nightly 25 builds don't update menulists of bootstrapped add-ons after browser restart or options page reopening

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Aris]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130801200732

Steps to reproduce:

I used 'Classic Toolbar Buttons' add-on for this example ( https://addons.mozilla.org/addon/cstbb/ ), but all others should be affected too: 

- open a bootstrapped add-ons options page
- change a menulist pref (btw pref does what it should)
- close add-ons manager or restart Firefox
- go to same add-ons options page
- look at recently changed menulist, it stays on first option although the one you have selected is active (I know that in this example, because I have selected a different icon set)


Actual results:

Menulist just keeps showing the first/default value although another one is active


Expected results:

The current selected menulist value should be shown instead the first/default one.

This is not an error of the add-on, because this 'bug' doesn't happen on latest Aurora, beta or final Firefox version, only on Nightly and UX builds.

Comment 1

[Aris]

More info: This bug first appeared with nightly 2013-08-02.

Comment 2

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/9d9856cf1648
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130801 Firefox/25.0 ID:20130801133513
Bad:
http://hg.mozilla.org/mozilla-central/rev/2ba2c2534fdb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130801 Firefox/25.0 ID:20130801172455
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9d9856cf1648&tochange=2ba2c2534fdb

Regression window(fx)
Good:
http://hg.mozilla.org/integration/fx-team/rev/85269a38f05e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130801 Firefox/25.0 ID:20130801015744
Bad:
http://hg.mozilla.org/integration/fx-team/rev/df15e6a39478
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130801 Firefox/25.0 ID:20130801050846
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=85269a38f05e&tochange=df15e6a39478


Regressed by:
 df15e6a39478	Geoff Lankow — Bug 888778 - Custom binding not applied to inline settings; r=Unfocused

Comment 3

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Also affects radio group settings. Looks like that constructor is not called.

Comment 4

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Attachment: 901341-1.diff

What's happening is the <menulist> doesn't have any XBL properties when we come to ask it for the itemCount. Don't ask me why. Setting the value attribute means that everything gets set up properly once the event loop gets around to it.

But! Setting the value attribute doesn't work, if the elements previously existed. So we need the original code too.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 785588 [details] [diff] [review]
901341-1.diff

Review of attachment 785588 [details] [diff] [review]:
-----------------------------------------------------------------

Have I mentioned recently how badly I want XBL2 to magically appear and (magically) solve all our problems?

::: toolkit/mozapps/extensions/test/browser/browser_inlinesettings.js
@@ +586,5 @@
> +  // Services.prefs.setIntPref("extensions.inlinesettings1.integer", 12);
> +  // Services.prefs.setCharPref("extensions.inlinesettings1.string", "bar/");
> +  // Services.prefs.setCharPref("extensions.inlinesettings1.color", "#FF9900");
> +  // Services.prefs.setCharPref("extensions.inlinesettings1.file", profD.path);
> +  // Services.prefs.setCharPref("extensions.inlinesettings1.directory", profD.path);

Leftover debug code? (And below)

Comment 6

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

https://hg.mozilla.org/integration/fx-team/rev/90282bb1cb8f

(In reply to Blair McBride [:Unfocused] from comment #5)
> Leftover debug code? (And below)

Not leftover, future-proofing. For when I change the earlier tests and then wonder why I get different results at this point. I've uncommented the code and commented as to why it is there.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/90282bb1cb8f

Comment 8

[Alex Keybl [:akeybl]]

Geoff, please request uplift to Aurora 25 when you get the chance. Thanks!

Comment 9

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Comment on attachment 785588 [details] [diff] [review]
901341-1.diff

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 888778
User impact if declined: add-on settings will be broken
Testing completed (on m-c, etc.): landed on m-c 3 days ago
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6e61e289443f