Closed
Bug 901425
Opened 12 years ago
Closed 12 years ago
Include customizableui/panelUIOverlay.css in theme browser.css files
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: MattN, Unassigned)
References
()
Details
(Whiteboard: [Australis:P-][Australis:M?])
My understanding was that we try to reduce the number of stylesheets in browser.xul for performance reasons. Perhaps omnijar has reduced the cost of additional CSS files but it's worth measuring.
|
Reporter | |
Comment 1•12 years ago
|
||
Baseline 3440be58f0ff
avgOpenTime:464.52
minOpenTime:355.35
maxOpenTime:895.56
%include in browser.css
avgOpenTime:464.43
minOpenTime:357.19
maxOpenTime:891.85
This seemed to have no effect on tpaint. I've done a try push to see if it affects ts_paint:
Base: https://tbpl.mozilla.org/?tree=Try&rev=69bbd8165e4e
Patch: https://tbpl.mozilla.org/?tree=Try&rev=6b58e5addef5
|
||
Updated•12 years ago
|
Whiteboard: [Australis:P?][Australis:M?]
|
|
||
Updated•12 years ago
|
Whiteboard: [Australis:P?][Australis:M?] → [Australis:P5][Australis:M?]
|
||
Comment 2•12 years ago
|
||
I don't think this is necessary per se (maybe even wontfix) but we do need to reorg our CSS files at some point. Up to Matt if we wontfix this.
Whiteboard: [Australis:P5][Australis:M?] → [Australis:P-][Australis:M?]
|
|
Reporter | |
Comment 3•12 years ago
|
||
I prefer them separate for maintainability unless there is a perf. benefit to combining them (which wasn't the case for ts_paint in comment 1).
Assignee: MattN+bmo → nobody
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•