901469 - Australis + Shiki Dust GTK/Murrine theme: bookmarking menu has white text, but light background (theme makes menus' bg black/dark).

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[[:Aleksej]]

Attachment: shiki-dust-australis-20130804-default.png

2013-08-04-04-02-17-ux-firefox-25.0a1.en-US.linux-x86_64

Debian GNU/Linux jessie with Xfce

Shiki-Dust theme (package cites http://code.google.com/p/gnome-colors/ as its source), which 
* makes the menu bars black with white text,
* the rest is supposed to be greyish with black text
(screenshot of a Shiki theme from its site: http://img113.imageshack.us/img113/706/867171.png ).

The drop-down menu of the right bookmarks button has white text on greyish background.

Installing dark LWT ("Black Elegance", "Black as Shiki") doesn't help.

Comment 1

[[:Aleksej]]

Attachment: LWT "Black Elegance" doesn't help

Comment 2

[Marco Bonardo [:mak]]

we must re-evaluate the styling in that panel, since it's also bad on Mac. Btw off-hand looks like a bug in the theme css, but it's early to fix it if the panel styling is not final.

Comment 3

[:Gijs (he/him)]

(In reply to Marco Bonardo [:mak] from comment #2)
> we must re-evaluate the styling in that panel, since it's also bad on Mac.
> Btw off-hand looks like a bug in the theme css, but it's early to fix it if
> the panel styling is not final.

I actually think comment #0 is talking about a Linux theme, which won't have CSS. We're probably specifying to use the system color for the view somewhere, but don't use the system background color...

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 785695 [details]
LWT "Black Elegance" doesn't help

Lightweight themes don't affect popups.

Comment 5

[:Gijs (he/him)]

So yeah. We're using color: menutext (or color: graytext), but using the background color of the panel, ie -moz-dialog. By happy coincidence, that works alright for common Windows/OS X combinations, but for more 'interesting' themes, it can be wrong. Like here. We should probably either style the menuitems inside the panel-esque menu (because it looks like it's still inside a menu popup, but with some panel arrows and such?) to have the right color, or we could style the panel to have a menu background color. The latter would also solve bug 900162. However, in that bug the word is that the arrow's background color is fixed.

Comment 6

[:Gijs (he/him)]

This was fixed by bug 900162.

Comment 7

[[:Aleksej]]

I am not sure which color menus are supposed to be (switching between themes in Xfce while programs are running mixes some themes up, Xfce, GNOME and Mozilla programs behave differently), but this is verified fixed with 2013-11-17-03-02-03-mozilla-central-firefox-28.0a1.en-US.linux-x86_64: attachment 8335990 [details] (showing bug 941576 though: the submenu arrows are almost invisible).

Comment 8

[[:Aleksej]]

(In reply to Aleksej [:Aleksej] from comment #7)

And note that the submenus which those arrows open are white on black.