901481 - Add an environment variable to set the number of entries kept by the profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[:Gijs (he/him)]

It's currently hardcoded at 1.000.000. For some usescases that's not enough (or too much, perhaps). So I'd like to be able to change it without having to recompile as I currently do... I'll see if I can whip up a patch for this.

Comment 1

[:Gijs (he/him)]

Attachment: add support for environment variables to control profiler

Something like this?

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 785794 [details] [diff] [review]
add support for environment variables to control profiler

Review of attachment 785794 [details] [diff] [review]:
-----------------------------------------------------------------

See also bug 873915 for more env. variables

::: tools/profiler/platform.h
@@ +237,5 @@
>  extern UnwMode sUnwindMode;       /* what mode? */
>  extern int     sUnwindInterval;   /* in milliseconds */
>  extern int     sUnwindStackScan;  /* max # of dubious frames allowed */
>  
> +/* Finally, we check a startup variable to see how many entries to store */

I don't think this comment is useful. :)

Comment 3

[:Gijs (he/him)]

(In reply to Benoit Girard (:BenWa) from comment #2)
> Comment on attachment 785794 [details] [diff] [review]
> add support for environment variables to control profiler
> 
> Review of attachment 785794 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> See also bug 873915 for more env. variables
> 
> ::: tools/profiler/platform.h
> @@ +237,5 @@
> >  extern UnwMode sUnwindMode;       /* what mode? */
> >  extern int     sUnwindInterval;   /* in milliseconds */
> >  extern int     sUnwindStackScan;  /* max # of dubious frames allowed */
> >  
> > +/* Finally, we check a startup variable to see how many entries to store */
> 
> I don't think this comment is useful. :)

Thanks! Pushed with the comment removed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/be8fddef6140

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be8fddef6140