Closed
Bug 901481
Opened 13 years ago
Closed 13 years ago
Add an environment variable to set the number of entries kept by the profiler
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Gijs, Assigned: Gijs)
Details
Attachments
(1 file)
|
6.07 KB,
patch
|
BenWa
:
review+
Gijs
:
checkin+
|
Details | Diff | Splinter Review |
It's currently hardcoded at 1.000.000. For some usescases that's not enough (or too much, perhaps). So I'd like to be able to change it without having to recompile as I currently do... I'll see if I can whip up a patch for this.
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Comment 2•13 years ago
|
||
Comment on attachment 785794 [details] [diff] [review]
add support for environment variables to control profiler
Review of attachment 785794 [details] [diff] [review]:
-----------------------------------------------------------------
See also bug 873915 for more env. variables
::: tools/profiler/platform.h
@@ +237,5 @@
> extern UnwMode sUnwindMode; /* what mode? */
> extern int sUnwindInterval; /* in milliseconds */
> extern int sUnwindStackScan; /* max # of dubious frames allowed */
>
> +/* Finally, we check a startup variable to see how many entries to store */
I don't think this comment is useful. :)
Attachment #785794 -
Flags: review?(bgirard) → review+
| Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #2)
> Comment on attachment 785794 [details] [diff] [review]
> add support for environment variables to control profiler
>
> Review of attachment 785794 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> See also bug 873915 for more env. variables
>
> ::: tools/profiler/platform.h
> @@ +237,5 @@
> > extern UnwMode sUnwindMode; /* what mode? */
> > extern int sUnwindInterval; /* in milliseconds */
> > extern int sUnwindStackScan; /* max # of dubious frames allowed */
> >
> > +/* Finally, we check a startup variable to see how many entries to store */
>
> I don't think this comment is useful. :)
Thanks! Pushed with the comment removed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be8fddef6140
Status: NEW → ASSIGNED
| Assignee | ||
Updated•13 years ago
|
Attachment #785794 -
Flags: checkin+
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•