Add an environment variable to set the number of entries kept by the profiler

RESOLVED FIXED in mozilla26

Status

()

enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
It's currently hardcoded at 1.000.000. For some usescases that's not enough (or too much, perhaps). So I'd like to be able to change it without having to recompile as I currently do... I'll see if I can whip up a patch for this.
(Assignee)

Comment 1

6 years ago
Something like this?
Attachment #785794 - Flags: review?(bgirard)
(Assignee)

Updated

6 years ago
Assignee: nobody → gijskruitbosch+bugs
Comment on attachment 785794 [details] [diff] [review]
add support for environment variables to control profiler

Review of attachment 785794 [details] [diff] [review]:
-----------------------------------------------------------------

See also bug 873915 for more env. variables

::: tools/profiler/platform.h
@@ +237,5 @@
>  extern UnwMode sUnwindMode;       /* what mode? */
>  extern int     sUnwindInterval;   /* in milliseconds */
>  extern int     sUnwindStackScan;  /* max # of dubious frames allowed */
>  
> +/* Finally, we check a startup variable to see how many entries to store */

I don't think this comment is useful. :)
Attachment #785794 - Flags: review?(bgirard) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Benoit Girard (:BenWa) from comment #2)
> Comment on attachment 785794 [details] [diff] [review]
> add support for environment variables to control profiler
> 
> Review of attachment 785794 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> See also bug 873915 for more env. variables
> 
> ::: tools/profiler/platform.h
> @@ +237,5 @@
> >  extern UnwMode sUnwindMode;       /* what mode? */
> >  extern int     sUnwindInterval;   /* in milliseconds */
> >  extern int     sUnwindStackScan;  /* max # of dubious frames allowed */
> >  
> > +/* Finally, we check a startup variable to see how many entries to store */
> 
> I don't think this comment is useful. :)

Thanks! Pushed with the comment removed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/be8fddef6140
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Attachment #785794 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/be8fddef6140
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.