901512 - [Contacts] Unable to finish the linking process when there has been an error while retrieving the picture of FB contact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[isabelrios]

Unagi device v1-train build

There should be at least one contact in the addressbook. 
STR
1. Open contacts app and select one contact
2. Tap on link contact
3. When the list of Facebook friends is shown, select one that has not charged the picture yet

EXPECTED
Both contacts are linked successfully

ACTUAL
After tapping on the FB contact the linking process starts but never ends. The device is not able to manage the error given while retrieving the picture of the contact so the linking process is stuck.

Marking as leo? since the functionality is not working

Comment 1

[Jose Manuel Cantera]

Attachment: 11351.html

Comment 2

[Alex Keybl [:akeybl]]

Fix looks simple, and this is embarassing. leo+

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 785800 [details]
11351.html

Nice, clean and simple since getFriendPicture already handles the timeout.

r+plusing


Thanks for the work JMC.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/a356920154f9bdcde0624092fe0ec5d7a3f40dfe

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 a356920154f9bdcde0624092fe0ec5d7a3f40dfe
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

Jose is on holidays, so I did the uplift to v1-train for him.

Just merged here:

https://github.com/mozilla-b2g/gaia/commit/dce27932836dfdf9645eae565bda084692ed1a1d

Cheers!
F.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: dce27932836dfdf9645eae565bda084692ed1a1d

Comment 8

[Jason Smith [:jsmith]]

This broke facebook import entirely. This needs to be backed out.

John - Can you back this out?

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

This was backed out with:

[v1-train 519ca3e] bug 905287 was caused by this commit.  Reverting "Merge pull request #11351 from jmcanterafonseca/fix_link_img"

Comment 10

[Jason Smith [:jsmith]]

Needs a branch-specific patch. bug 905287 works fine on master, but breaks fb import entirely on v1-train.

Comment 11

[Jason Smith [:jsmith]]

Also backed out on HD as well - https://bugzilla.mozilla.org/show_bug.cgi?id=905287#c5.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

@Jason,

thanks for checking this. The cherry picking from master to v1-train wasn't complicated at all, and unit test and basic testing were working for me.

We will need to investigate why v1-train is broken for this.

Thanks
F.

Comment 13

[Jose Manuel Cantera]

v1-train: https://github.com/mozilla-b2g/gaia/commit/3d879b3f6ca688348cf18f8f2572ccfd6849b13c

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 3d879b3f6ca688348cf18f8f2572ccfd6849b13c