Closed
Bug 901561
Opened 11 years ago
Closed 11 years ago
move CMSRCS to mozbuild.
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: joey, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.86 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Only one macro instance and there are config rules to handle the var so probably not a typo:
./toolkit/crashreporter/google-breakpad/src/common/mac/Makefile.in:CMSRCS = \
./config/rules.mk:CMOBJS = $(notdir $(CMSRCS:.m=.$(OBJ_SUFFIX)))
./config/rules.mk:$(foreach f,$(CSRCS) $(SSRCS) $(CPPSRCS) $(CMSRCS) $(CMMSRCS)
|
||
Comment 1•11 years ago
|
||
CMSRCS : CSRCS :: CMMSRCS : CPPSRCS
I guess we just don't have much ObjC (vs. ObjC++) in the tree. We could just see if this file compiles okay being put in CMMSRCS, and if so drop support for CMSRCS.
|
Assignee | |
Comment 2•11 years ago
|
||
It'd probably need to be renamed to .mm as well, because of:
CMOBJS = $(notdir $(CMSRCS:.m=.$(OBJ_SUFFIX)))
CMMOBJS = $(notdir $(CMMSRCS:.mm=.$(OBJ_SUFFIX)))
|
|
||
Comment 3•11 years ago
|
||
Oh, that's a bummer. Maybe we could just set CMOBJS and CMMOBJS by filtering CMMSRCS? I don't know.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #823976 -
Flags: review?(gps)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
|
||
Updated•11 years ago
|
Attachment #823976 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
Assignee | |
Updated•11 years ago
|
Blocks: xulinmozbuild
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•