901561 - move CMSRCS to mozbuild.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

Only one macro instance and there are config rules to handle the var so probably not a typo:

./toolkit/crashreporter/google-breakpad/src/common/mac/Makefile.in:CMSRCS = \

./config/rules.mk:CMOBJS = $(notdir $(CMSRCS:.m=.$(OBJ_SUFFIX)))
./config/rules.mk:$(foreach f,$(CSRCS) $(SSRCS) $(CPPSRCS) $(CMSRCS) $(CMMSRCS)

Comment 1

[(not currently active) Ted Mielczarek]

CMSRCS : CSRCS :: CMMSRCS : CPPSRCS

I guess we just don't have much ObjC (vs. ObjC++) in the tree. We could just see if this file compiles okay being put in CMMSRCS, and if so drop support for CMSRCS.

Comment 2

[Mike Hommey [:glandium]]

It'd probably need to be renamed to .mm as well, because of:
  CMOBJS = $(notdir $(CMSRCS:.m=.$(OBJ_SUFFIX)))
  CMMOBJS = $(notdir $(CMMSRCS:.mm=.$(OBJ_SUFFIX)))

Comment 3

[(not currently active) Ted Mielczarek]

Oh, that's a bummer. Maybe we could just set CMOBJS and CMMOBJS by filtering CMMSRCS? I don't know.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Move CMSRCS to moz.build

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a21754689419

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a21754689419