901597 - Add a way to control whether main thread and workers produce CC logs

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

Including all-traces options as needed.  There's some existing B2G infrastructure for dealing with logging and multiple processes, so maybe something related would work.

Comment 1

[Andrew McCreight [:mccr8]]

Workers can just use the same environment var stuff as the main thread, so this is fairly easy.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Move CC logging logic into nsCCParams.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Add environment var to CC log only main or worker threads.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8377664 [details] [diff] [review]
part 2 - Add environment var to CC log only main or worker threads.

Could you fix the documentation for MOZ_CC_LOG_THREAD to say that if it is not set, "all" is used as default.

const char *logThreadEnv
* should go with the type.

Comment 5

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/efa4c77cfa5f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b4fcc34583e4

Comment 6

[Andrew McCreight [:mccr8]]

Addressed review comments.

Comment 7

[Andrew McCreight [:mccr8]]

I updated the documentation to mention this:
  https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump

Comment 8

[Andrew McCreight [:mccr8]]

valgrind leaks
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d163502f0c6f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c2d5bb7172

Comment 9

[Andrew McCreight [:mccr8]]

It was another patch that was causing the leaks.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9c987f52f70f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/08b5793ca20e

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c987f52f70f
https://hg.mozilla.org/mozilla-central/rev/08b5793ca20e