901610 - Various uses of nsStyleDisplay::IsRelativelyPositioned

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect)

Comment 1

[Corey Ford [:coyotebush]]

Attachment: Use nsStyleDisplay::IsRelativelyPositioned in constructing frames for IB splits.

Comment 2

[Corey Ford [:coyotebush]]

Attachment: Use nsStyleDisplay::IsRelativelyPositionedStyle in nsLineLayout.

Comment 3

[Corey Ford [:coyotebush]]

Naturally, these will let position:sticky be acceptable in these locations (in combination with patch 2 from bug 886646).

A probably unnecessary try push: https://tbpl.mozilla.org/?tree=Try&rev=3ace7b5e825c

Comment 4

[Corey Ford [:coyotebush]]

Attachment: Use nsStyleDisplay::IsRelativelyPositioned in constructing frames for IB splits.

In ConstructInline, apparently aDisplay doesn't correspond to aParentFrame, so IsRelativelyPositioned was throwing assertions. Back to checking IsSVGText separately.

Comment 5

[Corey Ford [:coyotebush]]

Attachment: Use nsStyleDisplay::IsRelativelyPositioned in constructing frames for IB splits.

Comment 6

[Corey Ford [:coyotebush]]

Attachment: Use nsStyleDisplay::IsRelativelyPositionedStyle in nsLineLayout.

Code style tweaks to both patches.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 787040 [details] [diff] [review]
Use nsStyleDisplay::IsRelativelyPositioned in constructing frames for IB splits.

>       const nsStyleDisplay* parentDisplay = aParentFrame->StyleDisplay();
>-      bool positioned =
>-        parentDisplay->mPosition == NS_STYLE_POSITION_RELATIVE &&
>-        !aParentFrame->IsSVGText();
>+      bool positioned = parentDisplay->IsRelativelyPositioned(aParentFrame);

Drop |parentDisplay| too, and just use:

bool positioned = aParentFrame->IsRelativelyPositioned();



r=dbaron with that

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 787042 [details] [diff] [review]
Use nsStyleDisplay::IsRelativelyPositionedStyle in nsLineLayout.

r=dbaron

Comment 9

[Corey Ford [:coyotebush]]

Attachment: Use nsStyleDisplay::IsRelativelyPositioned in constructing frames for IB splits.

That's even better.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5323a7470f67
https://hg.mozilla.org/integration/mozilla-inbound/rev/7773265feff1

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5323a7470f67
https://hg.mozilla.org/mozilla-central/rev/7773265feff1