Closed Bug 901610 Opened 6 years ago Closed 6 years ago

Various uses of nsStyleDisplay::IsRelativelyPositioned

Categories

(Core :: Layout: Positioned, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: coyotebush, Assigned: coyotebush)

References

Details

Attachments

(2 files, 4 obsolete files)

No description provided.
Naturally, these will let position:sticky be acceptable in these locations (in combination with patch 2 from bug 886646).

A probably unnecessary try push: https://tbpl.mozilla.org/?tree=Try&rev=3ace7b5e825c
In ConstructInline, apparently aDisplay doesn't correspond to aParentFrame, so IsRelativelyPositioned was throwing assertions. Back to checking IsSVGText separately.
Attachment #785980 - Flags: review?(dbaron)
Attachment #785863 - Attachment is obsolete: true
Attachment #785863 - Flags: review?(dbaron)
Attachment #785864 - Flags: review?(dbaron)
Attachment #785980 - Flags: review?(dbaron)
Attachment #785980 - Attachment is obsolete: true
Code style tweaks to both patches.
Attachment #787042 - Flags: review?(dbaron)
Attachment #785864 - Attachment is obsolete: true
Comment on attachment 787040 [details] [diff] [review]
Use nsStyleDisplay::IsRelativelyPositioned in constructing frames for IB splits.

>       const nsStyleDisplay* parentDisplay = aParentFrame->StyleDisplay();
>-      bool positioned =
>-        parentDisplay->mPosition == NS_STYLE_POSITION_RELATIVE &&
>-        !aParentFrame->IsSVGText();
>+      bool positioned = parentDisplay->IsRelativelyPositioned(aParentFrame);

Drop |parentDisplay| too, and just use:

bool positioned = aParentFrame->IsRelativelyPositioned();



r=dbaron with that
Attachment #787040 - Flags: review?(dbaron) → review+
Comment on attachment 787042 [details] [diff] [review]
Use nsStyleDisplay::IsRelativelyPositionedStyle in nsLineLayout.

r=dbaron
Attachment #787042 - Flags: review?(dbaron) → review+
Attachment #787040 - Attachment is obsolete: true
Attachment #787204 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5323a7470f67
https://hg.mozilla.org/mozilla-central/rev/7773265feff1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.