901622 - Invalidate ProfileInformationCache after fixing add-on uninstallation

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Android, defect)

Description

[Richard Newman [:rnewman]]

Just about to uplift Bug 900694 to Beta (pre B1). We should fix existing badness, too.

Comment 1

[Richard Newman [:rnewman]]

Flaggin' for trackin'.

Release folks: this'll be the follow-on from Bug 900694 -- blowing away cached data to make sure we have an accurate snapshot of the user's add-ons, and are thus recording FHR events correctly.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://github.com/mozilla-services/android-sync/pull/345

r?

Comment 3

[Richard Newman [:rnewman]]

r+

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/3c188512a17c

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3c188512a17c

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 786979 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
    Initial landing of FHR and the fix deployed in Bug 900694 (already uplifted to 24).

User impact if declined: 
    Misrecorded addon data will propagate until cache is invalidated (which occurs on version bump - this patch - or corruption)

Testing completed (on m-c, etc.): 
    Tested locally, on m-c one week, unit tests via github (https://github.com/mozilla-services/android-sync/pull/345)

Risk to taking this patch (and alternatives if risky):
    Low risk - a version bump, whose behavior is tested by the unit tests linked above

String or IDL/UUID changes made by this patch:
    None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f66f82f71f6c
https://hg.mozilla.org/releases/mozilla-beta/rev/e04ea280b5de

Comment 9

[Aaron Train [:aaronmt]]

Covered by unit tests