901656 - nsIRadioGroupContainer can use HTMLInputElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Zbarsky (:dzbarsky)]

https://tbpl.mozilla.org/?tree=Try&rev=47eace04d8b2

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 785908 [details] [diff] [review]
Patch

Review of attachment 785908 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +1669,5 @@
>      static_cast<nsCycleCollectionTraversalCallback*>(aClosure);
>  
>    NS_CYCLE_COLLECTION_NOTE_EDGE_NAME(*cb,
>                                     "mRadioGroups entry->mSelectedRadioButton");
> +  cb->NoteXPCOMChild(static_cast<nsIContent*>(aData->mSelectedRadioButton));

ToSupports().

(Though it'd be nice if this could somehow use the macros...)

@@ +7297,5 @@
>  
>  NS_IMETHODIMP
>  nsDocument::GetNextRadioButton(const nsAString& aName,
>                                 const bool aPrevious,
> +                               HTMLInputElement*  aFocusedRadio,

Fix the extra space, please

@@ +7336,5 @@
>      }
>      else if (++index >= numRadios) {
>        index = 0;
>      }
> +    NS_ASSERTION(static_cast<nsGenericHTMLFormElement*>(radioGroup->mRadioButtons[index])->IsHTML(nsGkAtoms::input),

Ugh.

@@ +7344,2 @@
>  
>    NS_IF_ADDREF(*aRadioOut = radio);

Use forget() here.

::: content/base/src/nsDocument.h
@@ +727,5 @@
>                              nsIRadioVisitor* aVisitor,
>                              bool aFlushContent) MOZ_OVERRIDE;
>    virtual void SetCurrentRadioButton(const nsAString& aName,
> +                                     mozilla::dom::HTMLInputElement* aRadio) MOZ_OVERRIDE;
> +  virtual mozilla::dom::HTMLInputElement* GetCurrentRadioButton(const nsAString& aName) MOZ_OVERRIDE;

Fix any cases where you go over the 80-column limit

::: content/html/content/src/HTMLFormElement.cpp
@@ +287,5 @@
>  
>  // nsISupports
>  
>  static PLDHashOperator
> +ElementTraverser(const nsAString& key, HTMLInputElement* element,

I wonder if there's a macro for this already...

@@ +295,3 @@
>      static_cast<nsCycleCollectionTraversalCallback*>(userArg);
> +
> +  cb->NoteXPCOMChild(static_cast<nsIContent*>(element));

ToSupports

@@ +2137,5 @@
>  
>  NS_IMETHODIMP
>  HTMLFormElement::GetNextRadioButton(const nsAString& aName,
>                                      const bool aPrevious,
> +                                    HTMLInputElement*  aFocusedRadio,

Spaces

@@ +2182,4 @@
>      if (!radio)
>        continue;
>  
>      // XXXbz why is this formControl check needed, exactly?

formControl is gone

::: content/html/content/src/HTMLFormElement.h
@@ +81,3 @@
>    NS_IMETHOD GetNextRadioButton(const nsAString& aName,
>                                  const bool aPrevious,
> +                                HTMLInputElement*  aFocusedRadio,

Spaces

::: content/html/content/src/HTMLInputElement.cpp
@@ +3123,5 @@
>                      nsMouseEvent event(aVisitor.mEvent->mFlags.mIsTrusted,
>                                         NS_MOUSE_CLICK, nullptr,
>                                         nsMouseEvent::eReal);
>                      event.inputSource = nsIDOMMouseEvent::MOZ_SOURCE_KEYBOARD;
> +                    rv = nsEventDispatcher::Dispatch(static_cast<nsIContent*>(selectedRadioButton),

ToSupports()

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 785908 [details] [diff] [review]
Patch

>From: David Zbarsky <[e-mail]>
>nsidomhttlinput things...try: -b d -p linux64

Here too.

Comment 4

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/803d0a3d5307

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/803d0a3d5307