Closed Bug 901673 Opened 8 years ago Closed 8 years ago
Fix calls to "get
Plugin UI" in click-to-play UI code
See the changes at http://hg.mozilla.org/mozilla-central/rev/9a39f63704fa, the code/backend for the click-to-play UI changed. SeaMonkey CTP frontend code needs to adjust to this.
This should fix it, see http://hg.mozilla.org/mozilla-central/diff/9a39f63704fa/toolkit/mozapps/plugins/content/pluginProblem.xml for the relevant xbl changes. The doc and plugin variable are set above the big switch statement.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #785986 - Flags: review?(neil)
Comment on attachment 785986 [details] [diff] [review] Patch It looks as if six elements have switched from class to anonid. Maybe it would be better for getPluginUI to check both the class and the anonid?
Attachment #785986 - Flags: review?(neil) → review-
Comment on attachment 785986 [details] [diff] [review] Patch OK, so I was a little confused. In the case of vulnerabilityStatus we were already using the anonid. (But if we had a method that gets the UI element from the anonid then we could use that.) In the case of closeIcon either the class or the anonid works. And my sixth case was a false positive.
Attachment #785986 - Flags: review- → review+
Pushed: https://hg.mozilla.org/comm-central/rev/5bee28b4f499 Leaving bug open for landing on aurora later.
Comment on attachment 785986 [details] [diff] [review] Patch [Approval Request Comment] Regression caused by (bug #): Bug 888510 (mozilla-central checkin) User impact if declined: Broken click-to-play UI Testing completed (on m-c, etc.): Works fine on mozilla-central, automated tests pass (tested locally) Risk to taking this patch (and alternatives if risky): Very low risk String changes made by this patch: -
Bug 888510 landed on aurora before the uplift, so all release trains are affected
Attachment #785986 - Flags: approval-comm-aurora? → approval-comm-aurora+
Pushed to aurora: https://hg.mozilla.org/releases/comm-aurora/rev/9d2960c036b8
Attachment #785986 - Flags: approval-comm-beta? → approval-comm-beta+
Pushed to beta: https://hg.mozilla.org/releases/comm-beta/rev/0dfae252b6d1 Adjusting status-fixed flag so that the bug will appear in the correct bug queries.
Forgot to fix a test file.
Attachment #794951 - Flags: review+
Pushed: https://hg.mozilla.org/comm-central/rev/8c9b44d6b911 Pushed to aurora: https://hg.mozilla.org/releases/comm-aurora/rev/8d73909e4a3e Pushed to beta: https://hg.mozilla.org/releases/comm-beta/rev/58b303380eda Pushed with DONTBUILD except on beta to get some test results.
You need to log in before you can comment on or make changes to this bug.