Closed Bug 901673 Opened 8 years ago Closed 8 years ago

Fix calls to "getPluginUI" in click-to-play UI code

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(seamonkey2.21 fixed, seamonkey2.22 fixed)

RESOLVED FIXED
seamonkey2.23
Tracking Status
seamonkey2.21 --- fixed
seamonkey2.22 --- fixed

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

(Keywords: regression)

Attachments

(2 files)

See the changes at http://hg.mozilla.org/mozilla-central/rev/9a39f63704fa, the code/backend for the click-to-play UI changed. SeaMonkey CTP frontend code needs to adjust to this.
Attached patch PatchSplinter Review
This should fix it, see http://hg.mozilla.org/mozilla-central/diff/9a39f63704fa/toolkit/mozapps/plugins/content/pluginProblem.xml for the relevant xbl changes. The doc and plugin variable are set above the big switch statement.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #785986 - Flags: review?(neil)
Comment on attachment 785986 [details] [diff] [review]
Patch

It looks as if six elements have switched from class to anonid. Maybe it would be better for getPluginUI to check both the class and the anonid?
Attachment #785986 - Flags: review?(neil) → review-
Comment on attachment 785986 [details] [diff] [review]
Patch

OK, so I was a little confused.

In the case of vulnerabilityStatus we were already using the anonid. (But if we had a method that gets the UI element from the anonid then we could use that.)
In the case of closeIcon either the class or the anonid works.
And my sixth case was a false positive.
Attachment #785986 - Flags: review- → review+
Pushed: https://hg.mozilla.org/comm-central/rev/5bee28b4f499

Leaving bug open for landing on aurora later.
Comment on attachment 785986 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): Bug 888510 (mozilla-central checkin)
User impact if declined: Broken click-to-play UI
Testing completed (on m-c, etc.): Works fine on mozilla-central, automated tests pass (tested locally)
Risk to taking this patch (and alternatives if risky): Very low risk
String changes made by this patch: -
Attachment #785986 - Flags: approval-comm-beta?
Attachment #785986 - Flags: approval-comm-aurora?
Bug 888510 landed on aurora before the uplift, so all release trains are affected
OS: Windows 8 → All
Hardware: x86_64 → All
Attachment #785986 - Flags: approval-comm-aurora? → approval-comm-aurora+
Attachment #785986 - Flags: approval-comm-beta? → approval-comm-beta+
Pushed to beta: https://hg.mozilla.org/releases/comm-beta/rev/0dfae252b6d1
Adjusting status-fixed flag so that the bug will appear in the correct bug
queries.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attached patch Test fixSplinter Review
Forgot to fix a test file.
Attachment #794951 - Flags: review+
You need to log in before you can comment on or make changes to this bug.