901673 - Fix calls to "getPluginUI" in click-to-play UI code

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Frank Wein [:mcsmurf]]

See the changes at http://hg.mozilla.org/mozilla-central/rev/9a39f63704fa, the code/backend for the click-to-play UI changed. SeaMonkey CTP frontend code needs to adjust to this.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

This should fix it, see http://hg.mozilla.org/mozilla-central/diff/9a39f63704fa/toolkit/mozapps/plugins/content/pluginProblem.xml for the relevant xbl changes. The doc and plugin variable are set above the big switch statement.

Comment 2

[[e-mail]]

Comment on attachment 785986 [details] [diff] [review]
Patch

It looks as if six elements have switched from class to anonid. Maybe it would be better for getPluginUI to check both the class and the anonid?

Comment 3

[[e-mail]]

Comment on attachment 785986 [details] [diff] [review]
Patch

OK, so I was a little confused.

In the case of vulnerabilityStatus we were already using the anonid. (But if we had a method that gets the UI element from the anonid then we could use that.)
In the case of closeIcon either the class or the anonid works.
And my sixth case was a false positive.

Comment 4

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/5bee28b4f499

Leaving bug open for landing on aurora later.

Comment 5

[Frank Wein [:mcsmurf]]

Comment on attachment 785986 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): Bug 888510 (mozilla-central checkin)
User impact if declined: Broken click-to-play UI
Testing completed (on m-c, etc.): Works fine on mozilla-central, automated tests pass (tested locally)
Risk to taking this patch (and alternatives if risky): Very low risk
String changes made by this patch: -

Comment 6

[Frank Wein [:mcsmurf]]

Bug 888510 landed on aurora before the uplift, so all release trains are affected

Comment 7

[Frank Wein [:mcsmurf]]

Pushed to aurora: https://hg.mozilla.org/releases/comm-aurora/rev/9d2960c036b8

Comment 8

[Frank Wein [:mcsmurf]]

Pushed to beta: https://hg.mozilla.org/releases/comm-beta/rev/0dfae252b6d1
Adjusting status-fixed flag so that the bug will appear in the correct bug
queries.

Comment 9

[Frank Wein [:mcsmurf]]

Attachment: Test fix

Forgot to fix a test file.

Comment 10

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/8c9b44d6b911
Pushed to aurora: https://hg.mozilla.org/releases/comm-aurora/rev/8d73909e4a3e
Pushed to beta: https://hg.mozilla.org/releases/comm-beta/rev/58b303380eda

Pushed with DONTBUILD except on beta to get some test results.