Closed
Bug 901766
Opened 12 years ago
Closed 11 years ago
[fig] testSettingsMenuItems fails with "waitForText timeout on Enter Search"
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Margaret, Unassigned)
References
Details
(Whiteboard: [fixed-fig])
Attachments
(1 file)
1.68 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
It looks like this is happening because we're not showing the "Enter Search" placeholder text when dismissing the keyboard.
However, it's weird that this only started failing after I merged mozilla-central into fig over the weekend.
Reporter | ||
Updated•12 years ago
|
Priority: -- → P1
Comment 1•12 years ago
|
||
Attachment #786354 -
Flags: review?(liuche)
Comment 2•12 years ago
|
||
FYI: the test still fails even with this patch because two prefs are disabled/hidden, at least in my local fig build ("Telemetry" and "Automatic Updates"). Maybe they are properly enabled in tinderbox builds? If that's the case, this patch is probably enough. If not, then we can, for example, disable these entries in the test until we merge to m-c. Thoughts?
![]() |
||
Comment 3•12 years ago
|
||
I have seen that problem with "Automatic Updates" (not sure about Telemetry) with local builds on non-fig -- but it seems okay with tinderbox builds.
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #2)
> FYI: the test still fails even with this patch because two prefs are
> disabled/hidden, at least in my local fig build ("Telemetry" and "Automatic
> Updates"). Maybe they are properly enabled in tinderbox builds? If that's
> the case, this patch is probably enough. If not, then we can, for example,
> disable these entries in the test until we merge to m-c. Thoughts?
From IRC:
[06 09:51:57] <liuche> for local testing of settings, you need to disable a bunch of the datareporting
[06 09:52:05] <liuche> as well as the update over wifi
[06 09:52:17] <liuche> unless you have those flags enabled in your mozconfig
I suggested we document that in the test file itself, maybe when you land this patch you can add a comment explaining that :)
Comment 5•12 years ago
|
||
I filed a bug for commenting testSettingsMenuItems (bug 902035) because that should land on fx-team, since it's not fig-specific. I'll get a patch up for that bug.
Comment 6•12 years ago
|
||
I pushed these to try, and I'm curious about why the current version works on m-c but not on fig...
Anyways, I need to get my local robocop tests running again before I see what the behavior differences are, because they've mysteriously broken.
Comment 7•12 years ago
|
||
Comment on attachment 786354 [details] [diff] [review]
Fix handling of settings activity in testSettingsMenuItems
Review of attachment 786354 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Try push on top of fig is green.
I'd prefer to land this on fx-team/m-c, since about:home *shouldn't* change the behavior of settings, and I don't know why there's the extra two "backs" in the test. Still working on getting local test builds to run, and for some reason that's extremely broken :(
Attachment #786354 -
Flags: review?(liuche) → review+
Comment 8•12 years ago
|
||
Nevermind about landing on fx-team - verifyUrl on m-c clicks into the awesomescreen, and needs the extra back to exit from that.
Comment 9•12 years ago
|
||
Try build of the patch: https://tbpl.mozilla.org/?tree=Try&rev=61234c05ca9c
Comment 10•11 years ago
|
||
Landed on Fig: https://hg.mozilla.org/projects/fig/rev/1956f7c88b6f
Whiteboard: [fixed-fig]
Comment 11•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•