Closed Bug 901805 Opened 7 years ago Closed 7 years ago

reporting network activity in nsUDPServerSocket

Categories

(Core :: Networking, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: schien, Assigned: schien)

Details

Attachments

(1 file, 2 obsolete files)

The network activity notification only triggered by the traffic through nsSocketTransportService interfaces, however, nsUDPSocket uses NSPR directly. We'll need to invoke NetworkActivityMonitor::AttachIOLayer explicitly for the UDP socket.
Assignee: nobody → schien
Attachment #786202 - Flags: feedback?(jduell.mcbugs)
Make sure PR_Sendto is invoked on STS thread because NetworkActivityMonitor will check the current thread.
Attachment #795880 - Flags: review?(mcmanus)
Attachment #786202 - Attachment description: WIP - use NetworkActivityMonitor as a proxy for accessing udp socket → Part 2 - use NetworkActivityMonitor as a proxy for accessing udp socket
Attachment #786202 - Flags: feedback?(jduell.mcbugs) → review?(honzab.moz)
Attachment #786202 - Flags: review?(honzab.moz) → review+
Attachment #795880 - Flags: review?(mcmanus) → review+
The patch part 2 is not depending on the modification for UDP socket e10s. I'm thinking we can directly check patch part 2 solely in this bug and merge the patch part 1 into the modification for UDP socket e10s in bug 869869.
Honza and Patrick, how do you think?
Flags: needinfo?(mcmanus)
Flags: needinfo?(honzab.moz)
If that is simpler for you, then go ahead.  It's clear bug 869869 should land soon (blocks other 3 bugs, at least).  If postponing this bug will make landing that bug sooner, then it's a good thing to do.
Flags: needinfo?(honzab.moz)
Summary: reporting network activity in nsUDPSocket → reporting network activity in nsUDPServerSocket
I decide to make this bug independent from bug 869869.
No longer depends on: 869869
Flags: needinfo?(mcmanus)
https://hg.mozilla.org/mozilla-central/rev/76488552d101
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.