901856 - Add the new Notification API to the UITest test application

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

You're probably the best to handle this.

With this test, we can see that:
* the notification is correctly sent without crashing, so bug 901214 is maybe tied to the _remote_ mozbrowser iframe
* onclick and onclose handlers are not working, so some of the other patches do not work
* once we click on a notification in the "mozNotification" test, then no other test loads, and we need to kill the UITest app to make it work again. I haven't been able to find the cause.

Comment 2

[Gregor Wagner [:gwagner]]

Comment on attachment 786174 [details] [diff] [review]
patch v1

Review of attachment 786174 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

master: 84d5f12781e6f9bb5867189bb7f744e0a51cea6a

that was quick, thanks !

Comment 4

[Caio Lima(:caiolima)]

I'm having problems to access the patch. Could anyone verify it?

Comment 5

[Julien Wajsberg [:julienw]]

Caio> works for me. It's been checked in gaia master too so you might want to fetch and rebase to get it :)

Comment 6

[Caio Lima(:caiolima)]

It's not working on emulator. I've already tested it on Emulator and simulator with no success. 

The adb logcat reports that the Notifications is not a constructor. I don't have a phone to test It.

Comment 7

[Julien Wajsberg [:julienw]]

You need to use a emulator built from mozilla-central. I'm not aware of a simulator doing this.

Maybe you can take a b2g-desktop build from http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/, but I don't know how stable they are these days.

Comment 8

[Caio Lima(:caiolima)]

Build the emulator from mozilla-central is the same that have the gecko from mozilla-central? Because I've already done It. I've tested some changes in DesktopNotification.cpp from mozilla-central and It worked well, but I'm getting serious problems on enabling the "new Notification()" to my emulator.

Comment 9

[Julien Wajsberg [:julienw]]

Sorry, I can't help, I know nothing about the emulator.

Are you sure the pref is enabeld ?

Comment 10

[William Chen [:wchen]]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> Sorry, I can't help, I know nothing about the emulator.
> 
> Are you sure the pref is enabeld ?

It's pref'ed off in b2g right now. You'll need to add:
pref("dom.webnotifications.enabled", true);
to b2g/app/b2g.js

Comment 11

[Caio Lima(:caiolima)]

(In reply to William Chen [:wchen] from comment #10)
> It's pref'ed off in b2g right now. You'll need to add:
> pref("dom.webnotifications.enabled", true);
> to b2g/app/b2g.js

I've done it, but with no success.

Comment 12

[Gregor Wagner [:gwagner]]

(In reply to Caio Lima(:caiolima) from comment #11)
> (In reply to William Chen [:wchen] from comment #10)
> > It's pref'ed off in b2g right now. You'll need to add:
> > pref("dom.webnotifications.enabled", true);
> > to b2g/app/b2g.js
> 
> I've done it, but with no success.

It's enabled by default now:
https://hg.mozilla.org/mozilla-central/rev/06aecc131ac6