Closed
Bug 901856
Opened 12 years ago
Closed 12 years ago
Add the new Notification API to the UITest test application
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: julienw, Assigned: julienw)
Details
Attachments
(1 file)
22.25 KB,
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
You're probably the best to handle this.
With this test, we can see that:
* the notification is correctly sent without crashing, so bug 901214 is maybe tied to the _remote_ mozbrowser iframe
* onclick and onclose handlers are not working, so some of the other patches do not work
* once we click on a notification in the "mozNotification" test, then no other test loads, and we need to kill the UITest app to make it work again. I haven't been able to find the cause.
Attachment #786174 -
Flags: review?(anygregor)
Comment 2•12 years ago
|
||
Comment on attachment 786174 [details] [diff] [review]
patch v1
Review of attachment 786174 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #786174 -
Flags: review?(anygregor) → review+
Assignee | ||
Comment 3•12 years ago
|
||
master: 84d5f12781e6f9bb5867189bb7f744e0a51cea6a
that was quick, thanks !
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
I'm having problems to access the patch. Could anyone verify it?
Assignee | ||
Comment 5•11 years ago
|
||
Caio> works for me. It's been checked in gaia master too so you might want to fetch and rebase to get it :)
Comment 6•11 years ago
|
||
It's not working on emulator. I've already tested it on Emulator and simulator with no success.
The adb logcat reports that the Notifications is not a constructor. I don't have a phone to test It.
Assignee | ||
Comment 7•11 years ago
|
||
You need to use a emulator built from mozilla-central. I'm not aware of a simulator doing this.
Maybe you can take a b2g-desktop build from http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/, but I don't know how stable they are these days.
Comment 8•11 years ago
|
||
Build the emulator from mozilla-central is the same that have the gecko from mozilla-central? Because I've already done It. I've tested some changes in DesktopNotification.cpp from mozilla-central and It worked well, but I'm getting serious problems on enabling the "new Notification()" to my emulator.
Assignee | ||
Comment 9•11 years ago
|
||
Sorry, I can't help, I know nothing about the emulator.
Are you sure the pref is enabeld ?
Comment 10•11 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #9)
> Sorry, I can't help, I know nothing about the emulator.
>
> Are you sure the pref is enabeld ?
It's pref'ed off in b2g right now. You'll need to add:
pref("dom.webnotifications.enabled", true);
to b2g/app/b2g.js
Comment 11•11 years ago
|
||
(In reply to William Chen [:wchen] from comment #10)
> It's pref'ed off in b2g right now. You'll need to add:
> pref("dom.webnotifications.enabled", true);
> to b2g/app/b2g.js
I've done it, but with no success.
Comment 12•11 years ago
|
||
(In reply to Caio Lima(:caiolima) from comment #11)
> (In reply to William Chen [:wchen] from comment #10)
> > It's pref'ed off in b2g right now. You'll need to add:
> > pref("dom.webnotifications.enabled", true);
> > to b2g/app/b2g.js
>
> I've done it, but with no success.
It's enabled by default now:
https://hg.mozilla.org/mozilla-central/rev/06aecc131ac6
You need to log in
before you can comment on or make changes to this bug.
Description
•