Closed
Bug 901871
Opened 12 years ago
Closed 12 years ago
Plugin placeholder display incorrect in the Modern theme.
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(seamonkey2.22 fixed, seamonkey2.23 fixed)
RESOLVED
FIXED
seamonkey2.23
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
2.27 KB,
patch
|
mcsmurf
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Bug 888510 changed the plugin placeholder to binding pure HTML (they didn't remove the XUL namespace from the binding, but they could have). We need to port the relevant CSS changes. (We don't need to worry about the gradient performance cost because it's not the default theme.)
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
status-seamonkey2.22:
--- → affected
status-seamonkey2.23:
--- → affected
|
||
Comment 2•12 years ago
|
||
Comment on attachment 786185 [details] [diff] [review]
Proposed patch
BTW: I actually like the "Play" icon better in the Modern theme, they removed it from toolkit/Default theme now. Maybe should check if we can integrate it again.
Attachment #786185 -
Flags: review?(bugzilla) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 786185 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): 888510
User impact if declined: Suboptimal plugin placeholder display
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #786185 -
Flags: approval-comm-aurora?
Attachment #786185 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Assignee | |
Comment 5•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•