901903 - The guest profile is created at every startup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u421692]

Attachment: session_restore_log

Environment:
Device: LG Nexus 4 (Android 4.2.2)
Build: Nightly 25.0a1 (2013-08-05)

Steps to reproduce:
1. Open Firefox
2. Open Menu->Settings->Customize->Tabs and change to "Never restore" option
3. Restart Firefox to make sure changes take effect(after restarting the app "Never restore" is still checked).
4. Open three web pages, each one in a different tab. 
5. Restart/Kill Firefox.
6. Open Firefox.

Expected results:
Only "about:home" page is opened.

Actual results:
All the tabs from previous session are restored.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Using this doc as a guide:
https://wiki.mozilla.org/Mobile/SessionRestore

I would guess that step #5 would be considered a "manual kill" and should not restore tabs unless the setting was in "always".

Comment 2

[u421692]

No matter what settings I chose, the tabs are always restored.

Comment 4

[Brian Nicholson (:bnicholson)]

Looks like maybeCleanupGuestProfile() is broken and always returns true, which means we always do a restore: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java#415.

Here, we do getGuestDir() to prevent creating the dir, like the comment says: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoProfile.java#182. But then immediately after that, we call getGuestProfile(), so we're creating and then immediately removing the guest profile at every startup.

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Don't try to fetch guest profile if it doesn't exist

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 789183 [details] [diff] [review]
Don't try to fetch guest profile if it doesn't exist

Still doesn't work. The second problem is that Context#getDir (http://developer.android.com/reference/android/content/Context.html#getDir%28java.lang.String,%20int%29) creates the directory if it doesn't exist, but the code assumes it doesn't.

Comment 7

[Brian Nicholson (:bnicholson)]

Attachment: Don't try to fetch guest profile if it doesn't exist, v2

Changed to use getFileStreamPath (http://developer.android.com/reference/android/content/Context.html#getFileStreamPath%28java.lang.String%29) which gets the path without auto-creating anything.

Comment 8

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/75142ef8019a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75142ef8019a

Comment 10

[Brian Nicholson (:bnicholson)]

Comment on attachment 789196 [details] [diff] [review]
Don't try to fetch guest profile if it doesn't exist, v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 896092
User impact if declined: The session will always be restored at startup. The expected behavior is that if Fennec is swipe-killed, the session will not be restored. Should also improve startup performance by removing unnecessary I/O.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): very low risk
String or IDL/UUID changes made by this patch: none

Comment 11

[Aaron Train [:aaronmt]]

This broke Guest Mode on mozilla-central, see bug 906030.

Comment 12

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/375a555c99b2

Comment 13

[u421692]

Verified as fixed on:
Device: LG Nexus 4 (Android 4.2.2)
Build: Firefox 25 Beta 8 / Aurora 26.0a2 (2013-10-16)