90195 - Chrome listener has hardcoded behaviour

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Adam Lock]

Embedding's chrome listeners have hardcoded behaviour as regards to what tool
tip text is associated with a DOM node. Modify the chrome listener so that
embedders may register their own service to determine what text should be
returned when hovering over a DOM node.

Comment 1

[Adam Lock]

Attachment: Patch makes the tip text come from a service if one is registered, otherwise uses the default behaviour

Comment 2

[Adam Lock]

Attachment: Branch - Patch fixes a stupid, stupid typo that assertions and adds some extra pointer checking

Comment 3

[Adam Lock]

Apologies, last patch was to the trunk. Branch patch is coming after I sort out 
the different XPIDL semantics.

Comment 4

[Adam Lock]

Attachment: 0.9.2 branch patch

Comment 5

[Adam Lock]

Attachment: Sample text provider using the ActiveX control as harness

Comment 6

[Judson Valeski]

r=valeski

Comment 7

[rpotts (gone)]

sr=rpotts

looks good to me :-)

Comment 8

[Adam Lock]

Fix is checked into branch and trunk.

Comment 9

[lchiang]

mdunn - can you or someone from your team pls verify this?

Comment 10

[Michael Dunn]

David can you or Ashish try to verify?

Comment 11

[David Epstein]

Looks like another code verification. I'll take a look.

Comment 12

[David Epstein]

I verified that the tool tip provider and chrome listener code were checked into
the build. But it would be nice to have a test case to try this out. Anyone have
a code snippet which could verify this functionality? If not, QA will try
putting together a test case to pass tool tip text to the DOM node and provide a
listener to monitor it. Will investigate with other QA members who are more
familiar with these areas.

Comment 13

[Ashish Bhatt]

We tried the test case for this bug. We were able to register TooltipListener 
but the methods were'nt getting callbacks. We had trouble implementing the 
tooltiptextprovider interface (Needed to set the tooltip in the GetNodeText() 
method of the interface). Not able to find the header file for 
nsIToolTipTextProvider interface. David verified the code checkin for this bug.

Comment 14

[David Epstein]

verified