902064 - [fig] Folders on BookmarksList are throwing an IllegalArgumentException

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Enable sync.
Do a sync.
Tap on the "Desktop Bookmarks" folder row.
BAM! BOOM! DISH!! DASH!! DUMM!!
(oh! it was just a silent crash ;))

E/GeckoAppShell( 1085): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 11112 ("ModernAsyncTask #3")
E/GeckoAppShell( 1085): java.lang.IllegalArgumentException: the bind value at index 3 is null
E/GeckoAppShell( 1085): 	at android.database.sqlite.SQLiteProgram.bindString(SQLiteProgram.java:164)
E/GeckoAppShell( 1085): 	at android.database.sqlite.SQLiteProgram.bindAllArgsAsStrings(SQLiteProgram.java:200)
E/GeckoAppShell( 1085): 	at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:47)
E/GeckoAppShell( 1085): 	at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1314)
E/GeckoAppShell( 1085): 	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:400)
E/GeckoAppShell( 1085): 	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:333)
E/GeckoAppShell( 1085): 	at org.mozilla.gecko.db.BrowserProvider.query(BrowserProvider.java:2687)
E/GeckoAppShell( 1085): 	at android.content.ContentProvider.query(ContentProvider.java:744)
E/GeckoAppShell( 1085): 	at android.content.ContentProvider$Transport.query(ContentProvider.java:199)
E/GeckoAppShell( 1085): 	at android.content.ContentResolver.query(ContentResolver.java:414)
E/GeckoAppShell( 1085): 	at android.content.ContentResolver.query(ContentResolver.java:357)
E/GeckoAppShell( 1085): 	at org.mozilla.gecko.db.LocalBrowserDB.getFaviconsForUrls(LocalBrowserDB.java:767)
E/GeckoAppShell( 1085): 	at org.mozilla.gecko.db.BrowserDB.getFaviconsForUrls(BrowserDB.java:247)
E/GeckoAppShell( 1085): 	at org.mozilla.gecko.home.FaviconsLoader$FaviconsCursorLoader.loadCursor(FaviconsLoader.java:113)
E/GeckoAppShell( 1085): 	at org.mozilla.gecko.home.SimpleCursorLoader.loadInBackground(SimpleCursorLoader.java:49)
E/GeckoAppShell( 1085): 	at org.mozilla.gecko.home.SimpleCursorLoader.loadInBackground(SimpleCursorLoader.java:31)
E/GeckoAppShell( 1085): 	at android.support.v4.content.AsyncTaskLoader.onLoadInBackground(AsyncTaskLoader.java:242)
E/GeckoAppShell( 1085): 	at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:51)
E/GeckoAppShell( 1085): 	at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:40)
E/GeckoAppShell( 1085): 	at android.support.v4.content.ModernAsyncTask$2.call(ModernAsyncTask.java:123)
E/GeckoAppShell( 1085): 	at java.util.concurrent.FutureTask.run(FutureTask.java:234)
E/GeckoAppShell( 1085): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
E/GeckoAppShell( 1085): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
E/GeckoAppShell( 1085): 	at java.lang.Thread.run(Thread.java:841)

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

I don't understand the last diff and I didn't touch that line either.

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 786405 [details] [diff] [review]
Patch

Review of attachment 786405 [details] [diff] [review]:
-----------------------------------------------------------------

How often does this happen?

::: mobile/android/base/home/FaviconsLoader.java
@@ +44,5 @@
>              final String url = c.getString(c.getColumnIndexOrThrow(URLColumns.URL));
>  
>              // We only want to load favicons from DB if they are not in the
>              // memory cache yet.
> +            if (url == null || favicons.getFaviconFromMemCache(url) != null) {

Add a comment explanaining that URL is null when the item is a folder.

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/projects/fig/rev/a0175d7ee613

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a0175d7ee613